[PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

[PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

[Quytelda Kahja]

Changed a variable name from camel to snake case to fix a coding style
issue.

Signed-off-by: Quytelda Kahja <quytelda@gmail.com>
---
 drivers/staging/gdm724x/hci_packet.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h
index 22ce8b9477b6..f8837c7103ac 100644
--- a/drivers/staging/gdm724x/hci_packet.h
+++ b/drivers/staging/gdm724x/hci_packet.h
@@ -50,7 +50,7 @@ struct tlv {
 struct sdu_header {
 	__dev16 cmd_evt;
 	__dev16 len;
-	__dev32 dftEpsId;
+	__dev32 dft_eps_ID;
 	__dev32 bearer_ID;
 	__dev32 nic_type;
 } __packed;
-- 
2.16.2

Re: [PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

[Dan Carpenter]

On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
> Changed a variable name from camel to snake case to fix a coding style
> issue.
> 
> Signed-off-by: Quytelda Kahja <quytelda@gmail.com>
> ---
>  drivers/staging/gdm724x/hci_packet.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h
> index 22ce8b9477b6..f8837c7103ac 100644
> --- a/drivers/staging/gdm724x/hci_packet.h
> +++ b/drivers/staging/gdm724x/hci_packet.h
> @@ -50,7 +50,7 @@ struct tlv {
>  struct sdu_header {
>  	__dev16 cmd_evt;
>  	__dev16 len;
> -	__dev32 dftEpsId;
> +	__dev32 dft_eps_ID;

I bet this is a part of the user space ABI or there is a specific reason
for the name to match the spec or something so it can't be changed...

regards,
dan carpenter

Re: [PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

[Quytelda Kahja]

That could be the case, though I'm not sure where to find any specs.
Though looking through the history of this driver, it seems that some
of the variable names have been slowly changing from camel case to
snake case.

Thanks,
Quytelda Kahja

On Wed, Feb 21, 2018 at 2:45 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
>> Changed a variable name from camel to snake case to fix a coding style
>> issue.
>>
>> Signed-off-by: Quytelda Kahja <quytelda@gmail.com>
>> ---
>>  drivers/staging/gdm724x/hci_packet.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h
>> index 22ce8b9477b6..f8837c7103ac 100644
>> --- a/drivers/staging/gdm724x/hci_packet.h
>> +++ b/drivers/staging/gdm724x/hci_packet.h
>> @@ -50,7 +50,7 @@ struct tlv {
>>  struct sdu_header {
>>       __dev16 cmd_evt;
>>       __dev16 len;
>> -     __dev32 dftEpsId;
>> +     __dev32 dft_eps_ID;
>
> I bet this is a part of the user space ABI or there is a specific reason
> for the name to match the spec or something so it can't be changed...
>
> regards,
> dan carpenter
>

Re: [PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

[Dan Carpenter]

On Wed, Feb 21, 2018 at 03:15:54AM -0800, Quytelda Kahja wrote:
> That could be the case, though I'm not sure where to find any specs.
> Though looking through the history of this driver, it seems that some
> of the variable names have been slowly changing from camel case to
> snake case.
> 

Actually, that's fair enough.  This either is never tested or it doesn't
affect user space that much...  The change isn't any different from
other changes we've done.

regards,
dan carpenter

Re: [PATCH] Staging: gdm724x: hci: Changed camel-case to snake-case.

[Greg KH]

On Wed, Feb 21, 2018 at 01:45:58PM +0300, Dan Carpenter wrote:
> On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
> > Changed a variable name from camel to snake case to fix a coding style
> > issue.
> > 
> > Signed-off-by: Quytelda Kahja <quytelda@gmail.com>
> > ---
> >  drivers/staging/gdm724x/hci_packet.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h
> > index 22ce8b9477b6..f8837c7103ac 100644
> > --- a/drivers/staging/gdm724x/hci_packet.h
> > +++ b/drivers/staging/gdm724x/hci_packet.h
> > @@ -50,7 +50,7 @@ struct tlv {
> >  struct sdu_header {
> >  	__dev16 cmd_evt;
> >  	__dev16 len;
> > -	__dev32 dftEpsId;
> > +	__dev32 dft_eps_ID;
> 
> I bet this is a part of the user space ABI or there is a specific reason
> for the name to match the spec or something so it can't be changed...

This structure is not even used anywhere :(

Quytelda, can you just remove all unused structure definitions from this
driver?  That would be a much better patch here instead of changing a
structure field that no one uses.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel