* [PATCH] drm: fix drm_get_max_iomem type mismatch
@ 2018-02-22 11:47 Arnd Bergmann
2018-02-22 16:20 ` Sean Paul
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-02-22 11:47 UTC (permalink / raw)
To: Gustavo Padovan, Maarten Lankhorst, Sean Paul, David Airlie
Cc: Arnd Bergmann, Alex Deucher, Monk Liu, Christian König,
Michel Dänzer, Chunming Zhou, dri-devel, linux-kernel
When comparing two variables with min()/max(), they should be the same type:
drivers/gpu/drm/drm_memory.c: In function 'drm_get_max_iomem':
include/linux/kernel.h:821:16: error: comparison of distinct pointer types lacks a cast [-Werror]
(void) (&max1 == &max2);
This makes the local variable in drm_get_max_iomem make the type
from resource->end.
Fixes: 82626363a217 ("drm: add func to get max iomem address v2")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/drm_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
index 7ca500b8c399..3c54044214db 100644
--- a/drivers/gpu/drm/drm_memory.c
+++ b/drivers/gpu/drm/drm_memory.c
@@ -153,7 +153,7 @@ EXPORT_SYMBOL(drm_legacy_ioremapfree);
u64 drm_get_max_iomem(void)
{
struct resource *tmp;
- u64 max_iomem = 0;
+ resource_size_t max_iomem = 0;
for (tmp = iomem_resource.child; tmp; tmp = tmp->sibling) {
max_iomem = max(max_iomem, tmp->end);
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm: fix drm_get_max_iomem type mismatch
2018-02-22 11:47 [PATCH] drm: fix drm_get_max_iomem type mismatch Arnd Bergmann
@ 2018-02-22 16:20 ` Sean Paul
0 siblings, 0 replies; 2+ messages in thread
From: Sean Paul @ 2018-02-22 16:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Gustavo Padovan, Maarten Lankhorst, Sean Paul, David Airlie,
Alex Deucher, Monk Liu, Christian König, Michel Dänzer,
Chunming Zhou, dri-devel, linux-kernel
On Thu, Feb 22, 2018 at 12:47:51PM +0100, Arnd Bergmann wrote:
> When comparing two variables with min()/max(), they should be the same type:
>
> drivers/gpu/drm/drm_memory.c: In function 'drm_get_max_iomem':
> include/linux/kernel.h:821:16: error: comparison of distinct pointer types lacks a cast [-Werror]
> (void) (&max1 == &max2);
>
> This makes the local variable in drm_get_max_iomem make the type
> from resource->end.
>
> Fixes: 82626363a217 ("drm: add func to get max iomem address v2")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks Arnd, I've applied this to drm-misc-next.
Sean
> ---
> drivers/gpu/drm/drm_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
> index 7ca500b8c399..3c54044214db 100644
> --- a/drivers/gpu/drm/drm_memory.c
> +++ b/drivers/gpu/drm/drm_memory.c
> @@ -153,7 +153,7 @@ EXPORT_SYMBOL(drm_legacy_ioremapfree);
> u64 drm_get_max_iomem(void)
> {
> struct resource *tmp;
> - u64 max_iomem = 0;
> + resource_size_t max_iomem = 0;
>
> for (tmp = iomem_resource.child; tmp; tmp = tmp->sibling) {
> max_iomem = max(max_iomem, tmp->end);
> --
> 2.9.0
>
--
Sean Paul, Software Engineer, Google / Chromium OS
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-22 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-22 11:47 [PATCH] drm: fix drm_get_max_iomem type mismatch Arnd Bergmann
2018-02-22 16:20 ` Sean Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®