From: Viresh Kumar <viresh.kumar@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] cpufreq: scpi: drop redundant arm_big_little config dependency
Date: Fri, 23 Feb 2018 09:52:03 +0530 [thread overview]
Message-ID: <20180223042203.GC26947@vireshk-i7> (raw)
In-Reply-To: <1519322423-27956-1-git-send-email-sudeep.holla@arm.com>
On 22-02-18, 18:00, Sudeep Holla wrote:
Not sure if 'redundant' is the right term to be used here. I would
rather say: "Fix incorrect config dependency" :)
> Commit 343a8d17fa8d (cpufreq: scpi: remove arm_big_little dependency)
> removed the SCPI cpufreq dependency on arm_big_little cpufreq driver.
> However the Kconfig entry still depends on ARM_BIG_LITTLE_CPUFREQ
> which is clearly wrong.
>
> This patch removes that unnecessary Kconfig dependency.
>
> Fixes: 343a8d17fa8d (cpufreq: scpi: remove arm_big_little dependency)
> Reported-by: Quentin Perret <quentin.perret@arm.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/cpufreq/Kconfig.arm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 2e49673a9e21..9bbb5b39d18a 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -44,10 +44,10 @@ config ARM_DT_BL_CPUFREQ
>
> config ARM_SCPI_CPUFREQ
> tristate "SCPI based CPUfreq driver"
> - depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
> + depends on ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
> help
> - This adds the CPUfreq driver support for ARM big.LITTLE platforms
> - using SCPI protocol for CPU power management.
> + This adds the CPUfreq driver support for ARM platforms using SCPI
> + protocol for CPU power management.
>
> This driver uses SCPI Message Protocol driver to interact with the
> firmware providing the CPU DVFS functionality.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2018-02-23 4:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 18:00 Sudeep Holla
2018-02-23 4:22 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223042203.GC26947@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®