From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: PCI: MediaTek: fix dtc warnings
Date: Thu, 1 Mar 2018 14:50:18 +0000 [thread overview]
Message-ID: <20180301145018.GA2516@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <9940757fe2889f46d0de214c5f277bf3c2074205.1518577579.git.ryder.lee@mediatek.com>
On Wed, Feb 14, 2018 at 11:27:58AM +0800, Ryder Lee wrote:
> dtc recently added PCI bus checks. Fix these warnings:
>
> Warning (pci_bridge): Node /pcie@1a140000/pcie@0,0 missing bus-range for PCI bridge
> Warning (pci_bridge): Node /pcie@1a140000/pcie@1,0 missing bus-range for PCI bridge
> Warning (pci_bridge): Node /pcie@1a140000/pcie@2,0 missing bus-range for PCI bridge
> Warning (unit_address_format): Failed prerequisite 'pci_bridge'
> Warning (pci_device_reg): Failed prerequisite 'pci_bridge'
> Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge'
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Documentation/devicetree/bindings/pci/mediatek-pcie.txt | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
Given that changes to these bindings always went through the PCI tree,
I've applied this patch to pci/mediatek for v4.17, thanks.
Lorenzo
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
> index 3a6ce55..20227a8 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt
> @@ -78,7 +78,7 @@ Examples for MT7623:
> #reset-cells = <1>;
> };
>
> - pcie: pcie-controller@1a140000 {
> + pcie: pcie@1a140000 {
> compatible = "mediatek,mt7623-pcie";
> device_type = "pci";
> reg = <0 0x1a140000 0 0x1000>, /* PCIe shared registers */
> @@ -111,7 +111,6 @@ Examples for MT7623:
> 0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>; /* memory space */
>
> pcie@0,0 {
> - device_type = "pci";
> reg = <0x0000 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -123,7 +122,6 @@ Examples for MT7623:
> };
>
> pcie@1,0 {
> - device_type = "pci";
> reg = <0x0800 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -135,7 +133,6 @@ Examples for MT7623:
> };
>
> pcie@2,0 {
> - device_type = "pci";
> reg = <0x1000 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -148,6 +145,7 @@ Examples for MT7623:
> };
>
> Examples for MT2712:
> +
> pcie: pcie@11700000 {
> compatible = "mediatek,mt2712-pcie";
> device_type = "pci";
> @@ -169,7 +167,6 @@ Examples for MT2712:
> ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>;
>
> pcie0: pcie@0,0 {
> - device_type = "pci";
> reg = <0x0000 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -189,7 +186,6 @@ Examples for MT2712:
> };
>
> pcie1: pcie@1,0 {
> - device_type = "pci";
> reg = <0x0800 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -210,6 +206,7 @@ Examples for MT2712:
> };
>
> Examples for MT7622:
> +
> pcie: pcie@1a140000 {
> compatible = "mediatek,mt7622-pcie";
> device_type = "pci";
> @@ -243,7 +240,6 @@ Examples for MT7622:
> ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>;
>
> pcie0: pcie@0,0 {
> - device_type = "pci";
> reg = <0x0000 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> @@ -263,7 +259,6 @@ Examples for MT7622:
> };
>
> pcie1: pcie@1,0 {
> - device_type = "pci";
> reg = <0x0800 0 0 0 0>;
> #address-cells = <3>;
> #size-cells = <2>;
> --
> 1.9.1
>
prev parent reply other threads:[~2018-03-01 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 3:27 Ryder Lee
2018-02-19 3:10 ` Rob Herring
2018-03-01 14:50 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301145018.GA2516@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®