mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Nicholas Lowell <nlowell@lexmark.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: giving regulator controlling gpios a non-empty label when used through the devicetree
Date: Mon, 5 Mar 2018 15:40:36 +0000	[thread overview]
Message-ID: <20180305154036.GI8588@sirena.org.uk> (raw)
In-Reply-To: <CANnE4YfYihuhAa8TtdzDB+MR2njSwszFRvr2g+h=mcRjD-DiiQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On Fri, Mar 02, 2018 at 11:20:49AM -0500, Nicholas Lowell wrote:

> +++ b/drivers/regulator/gpio-regulator.c
> @@ -196,6 +196,7 @@ of_get_gpio_regulator_config(struct device *dev, struct
> device_node *np,
>   break;
>   }
>   config->gpios[i].gpio = gpio;
> + config->gpios[i].label = config->supply_name;
>   if (proplen > 0) {
>   of_property_read_u32_index(np, "gpios-states",
>      i, &ret);
> -- 
> 2.7.4

This patch is completely mangled, please see Documentation/SubmittingPatches
- it looks like tabs have been converted into single spaces and there's
some word wrapping going on.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

       reply	other threads:[~2018-03-05 15:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CANnE4YfYihuhAa8TtdzDB+MR2njSwszFRvr2g+h=mcRjD-DiiQ@mail.gmail.com>
2018-03-05 15:40 ` Mark Brown [this message]
2018-03-19 13:23 Nicholas Lowell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180305154036.GI8588@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nlowell@lexmark.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®