Re: [PATCH] regulator: giving regulator controlling gpios a non-empty label when used through the devicetree

Re: [PATCH] regulator: giving regulator controlling gpios a non-empty label when used through the devicetree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On Fri, Mar 02, 2018 at 11:20:49AM -0500, Nicholas Lowell wrote:

> +++ b/drivers/regulator/gpio-regulator.c
> @@ -196,6 +196,7 @@ of_get_gpio_regulator_config(struct device *dev, struct
> device_node *np,
>   break;
>   }
>   config->gpios[i].gpio = gpio;
> + config->gpios[i].label = config->supply_name;
>   if (proplen > 0) {
>   of_property_read_u32_index(np, "gpios-states",
>      i, &ret);
> -- 
> 2.7.4

This patch is completely mangled, please see Documentation/SubmittingPatches
- it looks like tabs have been converted into single spaces and there's
some word wrapping going on.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH] regulator: giving regulator controlling gpios a non-empty label when used through the devicetree.

[Nicholas Lowell]

When the label is empty, it causes missing information and limits diagnostics
for instances such as 'cat /sys/kernel/debug/gpio'

Setting the label to the regulator supply_name will point to the device
using the gpio(s).

Signed-off-by: Nicholas Lowell <nlowell@lexmark.com>
---
 drivers/regulator/gpio-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 0fce06a..b1f00e2 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -196,6 +196,7 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np,
 				break;
 			}
 			config->gpios[i].gpio = gpio;
+			config->gpios[i].label = config->supply_name;
 			if (proplen > 0) {
 				of_property_read_u32_index(np, "gpios-states",
 							   i, &ret);
-- 
2.7.4