* [PATCH] nds32: To use the generic dump_stack()
@ 2018-03-07 10:10 Greentime Hu
2018-03-07 10:42 ` Sergey Senozhatsky
0 siblings, 1 reply; 2+ messages in thread
From: Greentime Hu @ 2018-03-07 10:10 UTC (permalink / raw)
To: linux-kernel, arnd, greentime, green.hu, sergey.senozhatsky.work,
sergey.senozhatsky, sfr, peterz, pmladek
Use the generic dump_stack() instead of nds32 one because they are doing
the same thing.
Signed-off-by: Greentime Hu <greentime@andestech.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
arch/nds32/kernel/traps.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/arch/nds32/kernel/traps.c b/arch/nds32/kernel/traps.c
index 8828b4aeb72b..6e34eb9824a4 100644
--- a/arch/nds32/kernel/traps.c
+++ b/arch/nds32/kernel/traps.c
@@ -156,18 +156,6 @@ static void __dump(struct task_struct *tsk, unsigned long *base_reg)
pr_emerg("\n");
}
-void dump_stack(void)
-{
- unsigned long *base_reg;
- if (!IS_ENABLED(CONFIG_FRAME_POINTER))
- __asm__ __volatile__("\tori\t%0, $sp, #0\n":"=r"(base_reg));
- else
- __asm__ __volatile__("\tori\t%0, $fp, #0\n":"=r"(base_reg));
- __dump(NULL, base_reg);
-}
-
-EXPORT_SYMBOL(dump_stack);
-
void show_stack(struct task_struct *tsk, unsigned long *sp)
{
unsigned long *base_reg;
--
2.16.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nds32: To use the generic dump_stack()
2018-03-07 10:10 [PATCH] nds32: To use the generic dump_stack() Greentime Hu
@ 2018-03-07 10:42 ` Sergey Senozhatsky
0 siblings, 0 replies; 2+ messages in thread
From: Sergey Senozhatsky @ 2018-03-07 10:42 UTC (permalink / raw)
To: Greentime Hu
Cc: linux-kernel, arnd, greentime, sergey.senozhatsky.work,
sergey.senozhatsky, sfr, peterz, pmladek
On (03/07/18 18:10), Greentime Hu wrote:
>
> Use the generic dump_stack() instead of nds32 one because they are doing
> the same thing.
>
> Signed-off-by: Greentime Hu <greentime@andestech.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Thanks!
FWIW,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-07 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-07 10:10 [PATCH] nds32: To use the generic dump_stack() Greentime Hu
2018-03-07 10:42 ` Sergey Senozhatsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®