[PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")

[PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")

[ShuFan Lee]

From: ShuFan Lee <shufan_lee@richtek.com>

The parameter, dev_id, of tcpci_irq should be tcpci_chip.
Remove definition of TCPC_CC_STATUS_DRPRST in tcpci.h.

Signed-off-by: ShuFan Lee <shufan_lee@richtek.com>
Reviewed-by: Li Jun <jun.li@nxp.com>
Tested-by: Li Jun <jun.li@nxp.com>
---
 drivers/staging/typec/tcpci.c | 4 ++--
 drivers/staging/typec/tcpci.h | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 804374056a1e..076d97eaff6f 100644
--- a/drivers/staging/typec/tcpci.c
+++ b/drivers/staging/typec/tcpci.c
@@ -451,9 +451,9 @@ irqreturn_t tcpci_irq(struct tcpci *tcpci)
 
 static irqreturn_t _tcpci_irq(int irq, void *dev_id)
 {
-	struct tcpci *tcpci = dev_id;
+	struct tcpci_chip *chip = dev_id;
 
-	return tcpci_irq(tcpci);
+	return tcpci_irq(chip->tcpci);
 }
 
 static const struct regmap_config tcpci_regmap_config = {
diff --git a/drivers/staging/typec/tcpci.h b/drivers/staging/typec/tcpci.h
index a2c1754ca222..34c865f0dcf6 100644
--- a/drivers/staging/typec/tcpci.h
+++ b/drivers/staging/typec/tcpci.h
@@ -59,7 +59,6 @@
 #define TCPC_POWER_CTRL_VCONN_ENABLE	BIT(0)
 
 #define TCPC_CC_STATUS			0x1d
-#define TCPC_CC_STATUS_DRPRST		BIT(5)
 #define TCPC_CC_STATUS_TERM		BIT(4)
 #define TCPC_CC_STATUS_CC2_SHIFT	2
 #define TCPC_CC_STATUS_CC2_MASK		0x3
-- 
1.9.1

Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")

[Greg KH]

On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
> From: ShuFan Lee <shufan_lee@richtek.com>

Your subject is odd, that line should be below, in the signed-off-by:
area, not as the subject of the patch :(

Can you fix this up and resend?

thanks,

greg k-h

Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")

[李書帆]

Hi Greg,

2018-03-12 19:07 GMT+08:00 Greg KH <greg@kroah.com>:
> On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
>> From: ShuFan Lee <shufan_lee@richtek.com>
>
> Your subject is odd, that line should be below, in the signed-off-by:
> area, not as the subject of the patch :(
>
> Can you fix this up and resend?
Yes.
If I understand correctly, the title should be like
staging: typec: modify parameter of tcpci_irq
and the "Fixes" tag should be put in the signed-off-by area.

Should it be in the beginning of the area:
Fixes: 8f9439022648("staging: typec: handle vendor defined part and
modify drp toggling flow")
Signed-off-by: xxx

or the end of the area?
Signed-off-by: xxx
Fixes: 8f9439022648("staging: typec: handle vendor defined part and
modify drp toggling flow")

>
> thanks,
>
> greg k-h



-- 
Best Regards,
書帆

Re: [PATCH] Fixes: 8f9439022648("staging: typec: modify parameter of tcpci_irq")

[Greg KH]

On Mon, Mar 12, 2018 at 07:26:07PM +0800, 李書帆 wrote:
> Hi Greg,
> 
> 2018-03-12 19:07 GMT+08:00 Greg KH <greg@kroah.com>:
> > On Mon, Mar 12, 2018 at 05:46:42PM +0800, ShuFan Lee wrote:
> >> From: ShuFan Lee <shufan_lee@richtek.com>
> >
> > Your subject is odd, that line should be below, in the signed-off-by:
> > area, not as the subject of the patch :(
> >
> > Can you fix this up and resend?
> Yes.
> If I understand correctly, the title should be like
> staging: typec: modify parameter of tcpci_irq
> and the "Fixes" tag should be put in the signed-off-by area.

Correct.

> Should it be in the beginning of the area:
> Fixes: 8f9439022648("staging: typec: handle vendor defined part and
> modify drp toggling flow")
> Signed-off-by: xxx
> 
> or the end of the area?
> Signed-off-by: xxx
> Fixes: 8f9439022648("staging: typec: handle vendor defined part and
> modify drp toggling flow")

Either is acceptable, but usually you see the first example here.

thanks,

greg k-h