From: Daniel Scheller <d.scheller.oss@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Binoy Jayan <binoy.jayan@linaro.org>,
Jasmin Jessich <jasmin@anw.at>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: ngene: avoid unused variable warning
Date: Tue, 13 Mar 2018 17:38:44 +0100 [thread overview]
Message-ID: <20180313173844.0644a716@perian.wuest.de> (raw)
In-Reply-To: <20180313130620.4040088-1-arnd@arndb.de>
Am Tue, 13 Mar 2018 14:06:03 +0100
schrieb Arnd Bergmann <arnd@arndb.de>:
> The newly added pdev variable is only used in an #ifdef, causing a
> build warning without CONFIG_PCI_MSI, unless we move the declaration
> inside the same #ifdef:
>
> drivers/media/pci/ngene/ngene-core.c: In function 'ngene_start':
> drivers/media/pci/ngene/ngene-core.c:1328:17: error: unused variable 'pdev' [-Werror=unused-variable]
>
> Fixes: 6795bf626482 ("media: ngene: convert kernellog printing from printk() to dev_*() macros")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Daniel Scheller <d.scheller@gmx.net>
Thanks!
> ---
> drivers/media/pci/ngene/ngene-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/ngene/ngene-core.c b/drivers/media/pci/ngene/ngene-core.c
> index 3b9a1bfaf6c0..25f16833a475 100644
> --- a/drivers/media/pci/ngene/ngene-core.c
> +++ b/drivers/media/pci/ngene/ngene-core.c
> @@ -1325,7 +1325,6 @@ static int ngene_buffer_config(struct ngene *dev)
>
> static int ngene_start(struct ngene *dev)
> {
> - struct device *pdev = &dev->pci_dev->dev;
> int stat;
> int i;
>
> @@ -1359,6 +1358,7 @@ static int ngene_start(struct ngene *dev)
> #ifdef CONFIG_PCI_MSI
> /* enable MSI if kernel and card support it */
> if (pci_msi_enabled() && dev->card_info->msi_supported) {
> + struct device *pdev = &dev->pci_dev->dev;
> unsigned long flags;
>
> ngwritel(0, NGENE_INT_ENABLE);
Best regards,
Daniel Scheller
--
https://github.com/herrnst
prev parent reply other threads:[~2018-03-13 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 13:06 Arnd Bergmann
2018-03-13 16:38 ` Daniel Scheller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313173844.0644a716@perian.wuest.de \
--to=d.scheller.oss@gmail.com \
--cc=arnd@arndb.de \
--cc=binoy.jayan@linaro.org \
--cc=jasmin@anw.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®