From: kbuild test robot <lkp@intel.com>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: kbuild-all@01.org, linus.walleij@linaro.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org,
William Breathitt Gray <vilhelm.gray@gmail.com>
Subject: Re: [PATCH 4/8] gpio: pcie-idio-24: Implement get_multiple callback
Date: Tue, 13 Mar 2018 22:33:11 +0800 [thread overview]
Message-ID: <201803132231.8TQbRD8R%fengguang.wu@intel.com> (raw)
In-Reply-To: <5d46c780a6e3be82e672dbd17ba70d275e35b51b.1520886945.git.vilhelm.gray@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3396 bytes --]
Hi William,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.16-rc5 next-20180313]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Implement-get_multiple-for-ACCES-and-PC104-drivers/20180313-202244
config: x86_64-randconfig-x014-201810 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers//gpio/gpio-pcie-idio-24.c: In function 'idio_24_gpio_get_multiple':
>> drivers//gpio/gpio-pcie-idio-24.c:252:35: warning: 'port_state' may be used uninitialized in this function [-Wmaybe-uninitialized]
bits[BIT_WORD(i)] |= port_state << bit_word_offset;
~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
vim +/port_state +252 drivers//gpio/gpio-pcie-idio-24.c
195
196 static int idio_24_gpio_get_multiple(struct gpio_chip *chip,
197 unsigned long *mask, unsigned long *bits)
198 {
199 struct idio_24_gpio *const idio24gpio = gpiochip_get_data(chip);
200 struct idio_24_gpio_reg __iomem *const reg = idio24gpio->reg;
201 unsigned int i;
202 const unsigned int gpio_reg_size = 8;
203 unsigned int bit_word_offset;
204 unsigned int bits_mask;
205 const unsigned long reg_mask = GENMASK(gpio_reg_size, 0);
206 unsigned long port_state;
207 const unsigned long out_mode_mask = BIT(1);
208
209 /* clear bits array to a clean slate */
210 for (i = 0; i < chip->ngpio; i += BITS_PER_LONG)
211 bits[i / BITS_PER_LONG] = 0;
212
213 /* get bits are evaluated a gpio register size at a time */
214 for (i = 0; i < chip->ngpio; i += gpio_reg_size) {
215 bit_word_offset = i % BITS_PER_LONG;
216 bits_mask = mask[BIT_WORD(i)] & (reg_mask << bit_word_offset);
217 if (!bits_mask) {
218 /* no get bits in this register so skip to next one */
219 continue;
220 }
221
222 /* read bits from current gpio register */
223 switch (i / gpio_reg_size) {
224 case 0:
225 port_state = ioread8(®->out0_7);
226 break;
227 case 1:
228 port_state = ioread8(®->out8_15);
229 break;
230 case 2:
231 port_state = ioread8(®->out16_23);
232 break;
233 case 3:
234 port_state = ioread8(®->in0_7);
235 break;
236 case 4:
237 port_state = ioread8(®->in8_15);
238 break;
239 case 5:
240 port_state = ioread8(®->in16_23);
241 break;
242 case 6:
243 /* TTL/CMOS Outputs/Inputs */
244 if (ioread8(®->ctl) & out_mode_mask)
245 port_state = ioread8(®->ttl_out0_7);
246 else
247 port_state = ioread8(®->ttl_in0_7);
248 break;
249 }
250
251 /* store acquired bits */
> 252 bits[BIT_WORD(i)] |= port_state << bit_word_offset;
253 }
254
255 return 0;
256 }
257
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31983 bytes --]
next prev parent reply other threads:[~2018-03-13 14:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 20:48 [PATCH 0/8] Implement get_multiple for ACCES and PC104 drivers William Breathitt Gray
2018-03-12 20:48 ` [PATCH 1/8] iio: stx104: Implement get_multiple callback William Breathitt Gray
2018-03-12 20:48 ` [PATCH 2/8] gpio: 104-idio-16: " William Breathitt Gray
2018-03-12 20:49 ` [PATCH 3/8] gpio: pci-idio-16: " William Breathitt Gray
2018-03-13 14:32 ` kbuild test robot
2018-03-13 16:04 ` Andy Shevchenko
2018-03-13 20:20 ` William Breathitt Gray
2018-03-12 20:49 ` [PATCH 4/8] gpio: pcie-idio-24: " William Breathitt Gray
2018-03-13 14:33 ` kbuild test robot [this message]
2018-03-12 20:49 ` [PATCH 5/8] gpio: 104-dio-48e: " William Breathitt Gray
2018-03-12 20:49 ` [PATCH 6/8] gpio: 104-idi-48: " William Breathitt Gray
2018-03-12 20:50 ` [PATCH 7/8] gpio: gpio-mm: " William Breathitt Gray
2018-03-12 20:50 ` [PATCH 8/8] gpio: ws16c48: " William Breathitt Gray
2018-03-13 16:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201803132231.8TQbRD8R%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®