From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org,
William Breathitt Gray <vilhelm.gray@gmail.com>
Subject: [PATCH 3/8] gpio: pci-idio-16: Implement get_multiple callback
Date: Mon, 12 Mar 2018 16:49:07 -0400 [thread overview]
Message-ID: <e6a13288c45f824ba23ee8d1410cf0bf9c55fe60.1520886945.git.vilhelm.gray@gmail.com> (raw)
In-Reply-To: <cover.1520886945.git.vilhelm.gray@gmail.com>
The ACCES I/O PCI-IDIO-16 series of devices provides 16
optically-isolated digital inputs accessed via two 8-bit ports. Since
eight input lines are acquired on a single port input read, the
PCI-IDIO-16 GPIO driver may improve multiple input reads by utilizing a
get_multiple callback. This patch implements the
idio_16_gpio_get_multiple function which serves as the respective
get_multiple callback.
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-pci-idio-16.c | 48 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/drivers/gpio/gpio-pci-idio-16.c b/drivers/gpio/gpio-pci-idio-16.c
index 57d1b7fbf07b..8c5ec301c7ff 100644
--- a/drivers/gpio/gpio-pci-idio-16.c
+++ b/drivers/gpio/gpio-pci-idio-16.c
@@ -103,6 +103,53 @@ static int idio_16_gpio_get(struct gpio_chip *chip, unsigned int offset)
return !!(ioread8(&idio16gpio->reg->in8_15) & (mask >> 24));
}
+static int idio_16_gpio_get_multiple(struct gpio_chip *chip,
+ unsigned long *mask, unsigned long *bits)
+{
+ struct idio_16_gpio *const idio16gpio = gpiochip_get_data(chip);
+ unsigned int i;
+ const unsigned int gpio_reg_size = 8;
+ unsigned int bit_word_offset;
+ unsigned int bits_mask;
+ const unsigned long reg_mask = GENMASK(gpio_reg_size, 0);
+ unsigned long port_state;
+
+ /* clear bits array to a clean slate */
+ for (i = 0; i < chip->ngpio; i += BITS_PER_LONG)
+ bits[i / BITS_PER_LONG] = 0;
+
+ /* get bits are evaluated a gpio register size at a time */
+ for (i = 0; i < chip->ngpio; i += gpio_reg_size) {
+ bit_word_offset = i % BITS_PER_LONG;
+ bits_mask = mask[BIT_WORD(i)] & (reg_mask << bit_word_offset);
+ if (!bits_mask) {
+ /* no get bits in this register so skip to next one */
+ continue;
+ }
+
+ /* read bits from current gpio register */
+ switch (i / gpio_reg_size) {
+ case 0:
+ port_state = ioread8(&idio16gpio->reg->out0_7);
+ break;
+ case 1:
+ port_state = ioread8(&idio16gpio->reg->out8_15);
+ break;
+ case 2:
+ port_state = ioread8(&idio16gpio->reg->in0_7);
+ break;
+ case 3:
+ port_state = ioread8(&idio16gpio->reg->in8_15);
+ break;
+ }
+
+ /* store acquired bits */
+ bits[BIT_WORD(i)] |= port_state << bit_word_offset;
+ }
+
+ return 0;
+}
+
static void idio_16_gpio_set(struct gpio_chip *chip, unsigned int offset,
int value)
{
@@ -299,6 +346,7 @@ static int idio_16_probe(struct pci_dev *pdev, const struct pci_device_id *id)
idio16gpio->chip.direction_input = idio_16_gpio_direction_input;
idio16gpio->chip.direction_output = idio_16_gpio_direction_output;
idio16gpio->chip.get = idio_16_gpio_get;
+ idio16gpio->chip.get_multiple = idio_16_gpio_get_multiple;
idio16gpio->chip.set = idio_16_gpio_set;
idio16gpio->chip.set_multiple = idio_16_gpio_set_multiple;
--
2.16.2
next prev parent reply other threads:[~2018-03-12 20:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 20:48 [PATCH 0/8] Implement get_multiple for ACCES and PC104 drivers William Breathitt Gray
2018-03-12 20:48 ` [PATCH 1/8] iio: stx104: Implement get_multiple callback William Breathitt Gray
2018-03-12 20:48 ` [PATCH 2/8] gpio: 104-idio-16: " William Breathitt Gray
2018-03-12 20:49 ` William Breathitt Gray [this message]
2018-03-13 14:32 ` [PATCH 3/8] gpio: pci-idio-16: " kbuild test robot
2018-03-13 16:04 ` Andy Shevchenko
2018-03-13 20:20 ` William Breathitt Gray
2018-03-12 20:49 ` [PATCH 4/8] gpio: pcie-idio-24: " William Breathitt Gray
2018-03-13 14:33 ` kbuild test robot
2018-03-12 20:49 ` [PATCH 5/8] gpio: 104-dio-48e: " William Breathitt Gray
2018-03-12 20:49 ` [PATCH 6/8] gpio: 104-idi-48: " William Breathitt Gray
2018-03-12 20:50 ` [PATCH 7/8] gpio: gpio-mm: " William Breathitt Gray
2018-03-12 20:50 ` [PATCH 8/8] gpio: ws16c48: " William Breathitt Gray
2018-03-13 16:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6a13288c45f824ba23ee8d1410cf0bf9c55fe60.1520886945.git.vilhelm.gray@gmail.com \
--to=vilhelm.gray@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®