From: Valentin Vidic <Valentin.Vidic@CARNet.hr>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, "Derek Robson" <robsonde@gmail.com>,
"Michael Panzlaff" <michael.panzlaff@fau.de>,
"Valentin Vidic" <Valentin.Vidic@CARNet.hr>,
"Luca Söthe" <luca@acul.me>,
linux-kernel@vger.kernel.org,
"Marcin Ciupak" <marcin.s.ciupak@gmail.com>,
"Marcus Wolf" <linux@Wolf-Entwicklungen.de>,
"Simon Sandström" <simon@nikanor.nu>
Subject: [PATCH 1/7] staging: pi433: fix CamelCase for GPIO functions
Date: Wed, 14 Mar 2018 21:44:01 +0100 [thread overview]
Message-ID: <20180314204407.2777-1-Valentin.Vidic@CARNet.hr> (raw)
Fixes checkpatch warnings:
CHECK: Avoid CamelCase: <setup_GPIOs>
CHECK: Avoid CamelCase: <free_GPIOs>
Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
---
drivers/staging/pi433/pi433_if.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 5c6a7224180a..583b3803cf38 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -997,7 +997,7 @@ static int pi433_release(struct inode *inode, struct file *filp)
/*-------------------------------------------------------------------------*/
-static int setup_GPIOs(struct pi433_device *device)
+static int setup_gpio(struct pi433_device *device)
{
char name[5];
int retval;
@@ -1059,7 +1059,7 @@ static int setup_GPIOs(struct pi433_device *device)
return 0;
}
-static void free_GPIOs(struct pi433_device *device)
+static void free_gpio(struct pi433_device *device)
{
int i;
@@ -1174,7 +1174,7 @@ static int pi433_probe(struct spi_device *spi)
mutex_init(&device->rx_lock);
/* setup GPIO (including irq_handler) for the different DIOs */
- retval = setup_GPIOs(device);
+ retval = setup_gpio(device);
if (retval) {
dev_dbg(&spi->dev, "setup of GPIOs failed");
goto GPIO_failed;
@@ -1261,7 +1261,7 @@ static int pi433_probe(struct spi_device *spi)
device_create_failed:
pi433_free_minor(device);
minor_failed:
- free_GPIOs(device);
+ free_gpio(device);
GPIO_failed:
kfree(device);
@@ -1273,7 +1273,7 @@ static int pi433_remove(struct spi_device *spi)
struct pi433_device *device = spi_get_drvdata(spi);
/* free GPIOs */
- free_GPIOs(device);
+ free_gpio(device);
/* make sure ops on existing fds can abort cleanly */
device->spi = NULL;
--
2.16.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2018-03-14 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 20:44 Valentin Vidic [this message]
2018-03-14 20:44 ` [PATCH 2/7] staging: pi433: fix CamelCase for preambleLength variable Valentin Vidic
2018-03-14 20:44 ` [PATCH 3/7] staging: pi433: fix CamelCase for syncSize variable Valentin Vidic
2018-03-14 20:44 ` [PATCH 4/7] staging: pi433: fix CamelCase for bitRate variables Valentin Vidic
2018-03-14 20:44 ` [PATCH 5/7] staging: pi433: fix CamelCase for DIONumber variable Valentin Vidic
2018-03-14 20:44 ` [PATCH 6/7] staging: pi433: fix CamelCase for lnaGain enum Valentin Vidic
2018-03-14 20:44 ` [PATCH 7/7] staging: pi433: fix CamelCase for dagc enum Valentin Vidic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314204407.2777-1-Valentin.Vidic@CARNet.hr \
--to=valentin.vidic@carnet.hr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
--cc=luca@acul.me \
--cc=marcin.s.ciupak@gmail.com \
--cc=michael.panzlaff@fau.de \
--cc=robsonde@gmail.com \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®