From: Valentin Vidic <Valentin.Vidic@CARNet.hr>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, "Derek Robson" <robsonde@gmail.com>,
"Michael Panzlaff" <michael.panzlaff@fau.de>,
"Valentin Vidic" <Valentin.Vidic@CARNet.hr>,
"Luca Söthe" <luca@acul.me>,
linux-kernel@vger.kernel.org,
"Marcin Ciupak" <marcin.s.ciupak@gmail.com>,
"Marcus Wolf" <linux@Wolf-Entwicklungen.de>,
"Simon Sandström" <simon@nikanor.nu>
Subject: [PATCH 2/7] staging: pi433: fix CamelCase for preambleLength variable
Date: Wed, 14 Mar 2018 21:44:02 +0100 [thread overview]
Message-ID: <20180314204407.2777-2-Valentin.Vidic@CARNet.hr> (raw)
In-Reply-To: <20180314204407.2777-1-Valentin.Vidic@CARNet.hr>
Fixes checkpatch warning:
CHECK: Avoid CamelCase: <preambleLength>
Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
---
drivers/staging/pi433/rf69.c | 6 +++---
drivers/staging/pi433/rf69.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e5c7e48a3b86..b2c54999b022 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -590,7 +590,7 @@ int rf69_set_rssi_threshold(struct spi_device *spi, u8 threshold)
return rf69_write_reg(spi, REG_RSSITHRESH, threshold);
}
-int rf69_set_preamble_length(struct spi_device *spi, u16 preambleLength)
+int rf69_set_preamble_length(struct spi_device *spi, u16 preamble_length)
{
int retval;
u8 msb, lsb;
@@ -598,8 +598,8 @@ int rf69_set_preamble_length(struct spi_device *spi, u16 preambleLength)
/* no value check needed - u16 exactly matches register size */
/* calculate reg settings */
- msb = (preambleLength & 0xff00) >> 8;
- lsb = (preambleLength & 0xff);
+ msb = (preamble_length & 0xff00) >> 8;
+ lsb = (preamble_length & 0xff);
/* transmit to chip */
retval = rf69_write_reg(spi, REG_PREAMBLE_MSB, msb);
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index d83808a5dd86..78366f251084 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -44,7 +44,7 @@ int rf69_set_ook_threshold_dec(struct spi_device *spi, enum threshold_decrement
int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value);
bool rf69_get_flag(struct spi_device *spi, enum flag flag);
int rf69_set_rssi_threshold(struct spi_device *spi, u8 threshold);
-int rf69_set_preamble_length(struct spi_device *spi, u16 preambleLength);
+int rf69_set_preamble_length(struct spi_device *spi, u16 preamble_length);
int rf69_enable_sync(struct spi_device *spi);
int rf69_disable_sync(struct spi_device *spi);
int rf69_set_fifo_fill_condition(struct spi_device *spi, enum fifo_fill_condition fifo_fill_condition);
--
2.16.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-14 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 20:44 [PATCH 1/7] staging: pi433: fix CamelCase for GPIO functions Valentin Vidic
2018-03-14 20:44 ` Valentin Vidic [this message]
2018-03-14 20:44 ` [PATCH 3/7] staging: pi433: fix CamelCase for syncSize variable Valentin Vidic
2018-03-14 20:44 ` [PATCH 4/7] staging: pi433: fix CamelCase for bitRate variables Valentin Vidic
2018-03-14 20:44 ` [PATCH 5/7] staging: pi433: fix CamelCase for DIONumber variable Valentin Vidic
2018-03-14 20:44 ` [PATCH 6/7] staging: pi433: fix CamelCase for lnaGain enum Valentin Vidic
2018-03-14 20:44 ` [PATCH 7/7] staging: pi433: fix CamelCase for dagc enum Valentin Vidic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314204407.2777-2-Valentin.Vidic@CARNet.hr \
--to=valentin.vidic@carnet.hr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
--cc=luca@acul.me \
--cc=marcin.s.ciupak@gmail.com \
--cc=michael.panzlaff@fau.de \
--cc=robsonde@gmail.com \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®