From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Barry Song <21cnbao@gmail.com>,
linux-kernel@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
daniel.baluta@nxp.com, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 7/7] staging:iio:ade7854: Add proper error handling condition
Date: Thu, 15 Mar 2018 15:11:15 +0300 [thread overview]
Message-ID: <20180315121115.iwkx2dfikgpjeeec@mwanda> (raw)
In-Reply-To: <72d5aaef3445edaca08498b4d7aaff19d4ac0232.1521037060.git.rodrigosiqueiramelo@gmail.com>
On Wed, Mar 14, 2018 at 03:12:18PM -0300, Rodrigo Siqueira wrote:
> There is some improper error handling for IRQ and device register. This
> patch adds a proper verification. The IRQ correction was extracted from
> John Syne patches.
>
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> Signed-off-by: John Syne <john3909@gmail.com>
> ---
> drivers/staging/iio/meter/ade7854.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c
> index 09fd8c067738..49cbe365e43d 100644
> --- a/drivers/staging/iio/meter/ade7854.c
> +++ b/drivers/staging/iio/meter/ade7854.c
> @@ -436,7 +436,7 @@ static int ade7854_initial_setup(struct iio_dev *indio_dev)
>
> /* Disable IRQ */
> ret = ade7854_set_irq(dev, false);
> - if (ret) {
> + if (ret < 0) {
> dev_err(dev, "disable irq failed");
> goto err_ret;
> }
Why is the original wrong? It seems fine.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-15 12:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 18:10 [PATCH 0/7] staging:iio:ade7854: Cleanup on I2C/SPI code Rodrigo Siqueira
2018-03-14 18:10 ` [PATCH 1/7] staging:iio:ade7854: Rework I2C write function Rodrigo Siqueira
2018-03-15 12:06 ` Dan Carpenter
2018-03-16 0:25 ` Rodrigo Siqueira
2018-03-14 18:10 ` [PATCH 2/7] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-14 18:10 ` [PATCH 3/7] staging:iio:ade7854: Replace many functions for one function Rodrigo Siqueira
2018-03-14 18:11 ` [PATCH 4/7] staging:iio:ade7854: Rework I2C read function Rodrigo Siqueira
2018-03-14 18:11 ` [PATCH 5/7] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-14 18:11 ` [PATCH 6/7] staging:iio:ade7854: Remove read_reg_* duplications Rodrigo Siqueira
2018-03-14 18:12 ` [PATCH 7/7] staging:iio:ade7854: Add proper error handling condition Rodrigo Siqueira
2018-03-15 12:11 ` Dan Carpenter [this message]
2018-03-16 0:28 ` Rodrigo Siqueira
2018-03-16 8:02 ` Dan Carpenter
2018-03-16 13:59 ` Rodrigo Siqueira
2018-03-16 14:17 ` Dan Carpenter
2018-03-16 20:03 ` Rodrigo Siqueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315121115.iwkx2dfikgpjeeec@mwanda \
--to=dan.carpenter@oracle.com \
--cc=21cnbao@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome