mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Barry Song <21cnbao@gmail.com>,
	linux-kernel@vger.kernel.org,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Hartmut Knaack <knaack.h@gmx.de>,
	daniel.baluta@nxp.com, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 7/7] staging:iio:ade7854: Add proper error handling condition
Date: Fri, 16 Mar 2018 17:03:53 -0300	[thread overview]
Message-ID: <20180316200353.dgcdiduupslxtmng@smtp.gmail.com> (raw)
In-Reply-To: <20180316141727.ia3mrwnmtkge7elm@mwanda>

On 03/16, Dan Carpenter wrote:
> Generally, it's better to fix the bug in the existing code, and then
> do the cleanup later.  That way the fixes can be backported to stable
> kernels more easily.

Hummm... the backport argue make a lot of sense for me. I will generate
a v2 with the bug fixes in the beginning.

Thanks 
> I don't know this subsystem very well.  Perhaps Jonathan doesn't care
> for one reason or another (like maybe he's not going to back port the
> fix).  So it might not matter how you do it.
> 
> regards,
> dan carpenter
> 
> 
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      reply	other threads:[~2018-03-16 20:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 18:10 [PATCH 0/7] staging:iio:ade7854: Cleanup on I2C/SPI code Rodrigo Siqueira
2018-03-14 18:10 ` [PATCH 1/7] staging:iio:ade7854: Rework I2C write function Rodrigo Siqueira
2018-03-15 12:06   ` Dan Carpenter
2018-03-16  0:25     ` Rodrigo Siqueira
2018-03-14 18:10 ` [PATCH 2/7] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-14 18:10 ` [PATCH 3/7] staging:iio:ade7854: Replace many functions for one function Rodrigo Siqueira
2018-03-14 18:11 ` [PATCH 4/7] staging:iio:ade7854: Rework I2C read function Rodrigo Siqueira
2018-03-14 18:11 ` [PATCH 5/7] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-14 18:11 ` [PATCH 6/7] staging:iio:ade7854: Remove read_reg_* duplications Rodrigo Siqueira
2018-03-14 18:12 ` [PATCH 7/7] staging:iio:ade7854: Add proper error handling condition Rodrigo Siqueira
2018-03-15 12:11   ` Dan Carpenter
2018-03-16  0:28     ` Rodrigo Siqueira
2018-03-16  8:02       ` Dan Carpenter
2018-03-16 13:59         ` Rodrigo Siqueira
2018-03-16 14:17           ` Dan Carpenter
2018-03-16 20:03             ` Rodrigo Siqueira [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180316200353.dgcdiduupslxtmng@smtp.gmail.com \
    --to=rodrigosiqueiramelo@gmail.com \
    --cc=21cnbao@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome