mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [martinbrandenburg:for-next 20/24] fs/orangefs/file.c:586:5: sparse: symbol 'orangefs_flush' was not declared. Should it be static?
@ 2018-03-16  8:15 kbuild test robot
  2018-03-16  8:15 ` [RFC PATCH martinbrandenburg] orangefs: orangefs_write_end() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-03-16  8:15 UTC (permalink / raw)
  To: Martin Brandenburg; +Cc: kbuild-all, Mike Marshall, devel, linux-kernel

tree:   https://github.com/martinbrandenburg/linux for-next
head:   f73753424e408389a77bcfa9b04beb41f0f6b2f8
commit: 27dd09ddfeca4937da105e89ded1ba3d35e1038e [20/24] orangefs: implement writepage
reproduce:
        # apt-get install sparse
        git checkout 27dd09ddfeca4937da105e89ded1ba3d35e1038e
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   fs/orangefs/file.c:428:35: sparse: symbol 'orangefs_file_vm_ops' was not declared. Should it be static?
>> fs/orangefs/file.c:586:5: sparse: symbol 'orangefs_flush' was not declared. Should it be static?
--
>> fs/orangefs/inode.c:88:5: sparse: symbol 'orangefs_write_end' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH martinbrandenburg] orangefs: orangefs_write_end() can be static
  2018-03-16  8:15 [martinbrandenburg:for-next 20/24] fs/orangefs/file.c:586:5: sparse: symbol 'orangefs_flush' was not declared. Should it be static? kbuild test robot
@ 2018-03-16  8:15 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-03-16  8:15 UTC (permalink / raw)
  To: Martin Brandenburg; +Cc: kbuild-all, Mike Marshall, devel, linux-kernel


Fixes: 27dd09ddfeca ("orangefs: implement writepage")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c
index b9b9d65..9999151 100644
--- a/fs/orangefs/inode.c
+++ b/fs/orangefs/inode.c
@@ -85,7 +85,7 @@ static int orangefs_readpage(struct file *file, struct page *page)
 	return ret;
 }
 
-int orangefs_write_end(struct file *file, struct address_space *mapping,
+static int orangefs_write_end(struct file *file, struct address_space *mapping,
     loff_t pos, unsigned len, unsigned copied, struct page *page, void *fsdata)
 {
 	int r;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-16  8:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-16  8:15 [martinbrandenburg:for-next 20/24] fs/orangefs/file.c:586:5: sparse: symbol 'orangefs_flush' was not declared. Should it be static? kbuild test robot
2018-03-16  8:15 ` [RFC PATCH martinbrandenburg] orangefs: orangefs_write_end() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®