mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ioana Radulescu <ruxandra.radulescu@nxp.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 8/9] staging: fsl-dpaa2/eth: Fix SGT allocation
Date: Fri, 23 Mar 2018 08:44:12 -0500	[thread overview]
Message-ID: <20180323134413.1532-9-ruxandra.radulescu@nxp.com> (raw)
In-Reply-To: <20180323134413.1532-1-ruxandra.radulescu@nxp.com>

We mistakenly allocate space for too many entries in the
scatter-gather table of multi buffer egress frames.

While it doesn't have a negative impact from a functional
point of view, it wastes resources so fix it.

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
---
 drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
index 9994922..14bd8fe 100644
--- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
+++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
@@ -373,7 +373,7 @@ static int build_sg_fd(struct dpaa2_eth_priv *priv,
 
 	/* Prepare the HW SGT structure */
 	sgt_buf_size = priv->tx_data_offset +
-		       sizeof(struct dpaa2_sg_entry) * (1 + num_dma_bufs);
+		       sizeof(struct dpaa2_sg_entry) *  num_dma_bufs;
 	sgt_buf = netdev_alloc_frag(sgt_buf_size + DPAA2_ETH_TX_BUF_ALIGN);
 	if (unlikely(!sgt_buf)) {
 		err = -ENOMEM;
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2018-03-23 13:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23 13:44 [PATCH 0/9] staging: fsl-dpaa2/eth: Cleanup Ioana Radulescu
2018-03-23 13:44 ` [PATCH 1/9] staging: fsl-dpaa2/eth: Use generic irq handler Ioana Radulescu
2018-03-23 13:44 ` [PATCH 2/9] staging: fsl-dpaa2/eth: Move print message Ioana Radulescu
2018-03-23 15:01   ` Greg KH
2018-03-23 15:03     ` Ruxandra Ioana Ciocoi Radulescu
2018-03-23 15:06       ` Greg KH
2018-03-23 13:44 ` [PATCH 3/9] staging: fsl-dpaa2/eth: Remove unused field Ioana Radulescu
2018-03-23 13:44 ` [PATCH 4/9] staging: fsl-dpaa2/eth: Remove packed attribute Ioana Radulescu
2018-03-23 13:44 ` [PATCH 5/9] staging: fsl-dpaa2/eth: Add DPNI version check Ioana Radulescu
2018-03-23 13:44 ` [PATCH 6/9] staging: fsl-dpaa2/eth: Change link settings on the fly Ioana Radulescu
2018-03-23 13:44 ` [PATCH 7/9] staging: fsl-dpaa2/eth: Cleanup TX frame freeing code Ioana Radulescu
2018-03-23 13:44 ` Ioana Radulescu [this message]
2018-03-23 13:44 ` [PATCH 9/9] staging: fsl-dpaa2/eth: Change max number of Tx queues Ioana Radulescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180323134413.1532-9-ruxandra.radulescu@nxp.com \
    --to=ruxandra.radulescu@nxp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®