From: Peter Zijlstra <peterz@infradead.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 1/3] i2c: update i2c_trace_msg static key to modern api
Date: Mon, 26 Mar 2018 10:34:04 +0200 [thread overview]
Message-ID: <20180326083404.GF4043@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180325191056.24598-2-dave@stgolabs.net>
On Sun, Mar 25, 2018 at 12:10:54PM -0700, Davidlohr Bueso wrote:
> @@ -1848,11 +1848,11 @@ int __i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
> if (adap->quirks && i2c_check_for_quirks(adap, msgs, num))
> return -EOPNOTSUPP;
>
> - /* i2c_trace_msg gets enabled when tracepoint i2c_transfer gets
> + /* i2c_trace_msg_key gets enabled when tracepoint i2c_transfer gets
> * enabled. This is an efficient way of keeping the for-loop from
> * being executed when not needed.
> */
> - if (static_key_false(&i2c_trace_msg)) {
> + if (static_branch_unlikely(&i2c_trace_msg_key)) {
broken comment style.
next prev parent reply other threads:[~2018-03-26 8:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 19:10 [PATCH -next 0/3] update some static key users " Davidlohr Bueso
2018-03-25 19:10 ` [PATCH 1/3] i2c: update i2c_trace_msg static key " Davidlohr Bueso
2018-03-26 8:33 ` Peter Zijlstra
2018-03-26 8:34 ` Peter Zijlstra [this message]
2018-03-25 19:10 ` [PATCH 2/3] drivers/irqchip: update supports_deactivate " Davidlohr Bueso
2018-03-26 8:17 ` Marc Zyngier
2018-03-26 13:54 ` Davidlohr Bueso
2018-03-26 14:24 ` Marc Zyngier
2018-03-26 19:57 ` Davidlohr Bueso
2018-03-26 8:34 ` Peter Zijlstra
2018-03-26 8:34 ` Peter Zijlstra
2018-03-25 19:10 ` [PATCH 3/3] sched/core: update preempt_notifier_key " Davidlohr Bueso
2018-03-26 8:35 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326083404.GF4043@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome