From: Marc Zyngier <marc.zyngier@arm.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: peterz@infradead.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 2/3] drivers/irqchip: update supports_deactivate static key to modern api
Date: Mon, 26 Mar 2018 15:24:11 +0100 [thread overview]
Message-ID: <56064180-053b-2987-d10e-7e5f36c579a1@arm.com> (raw)
In-Reply-To: <20180326135456.a6z6tvbx2kdqbopr@linux-n805>
On 26/03/18 14:54, Davidlohr Bueso wrote:
> On Mon, 26 Mar 2018, Marc Zyngier wrote:
>
>>> static struct gic_chip_data gic_data __read_mostly;
>>> -static struct static_key supports_deactivate = STATIC_KEY_INIT_TRUE;
>>> +DEFINE_STATIC_KEY_TRUE(supports_deactivate_key);
>>
>> When you combine this...
>>
>> [...]
>>
>>> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
>>> index ac2e62d613d1..9b7630cee56c 100644
>>> --- a/drivers/irqchip/irq-gic.c
>>> +++ b/drivers/irqchip/irq-gic.c
>>> @@ -121,7 +121,7 @@ static DEFINE_RAW_SPINLOCK(cpu_map_lock);
>>> #define NR_GIC_CPU_IF 8
>>> static u8 gic_cpu_map[NR_GIC_CPU_IF] __read_mostly;
>>>
>>> -static struct static_key supports_deactivate = STATIC_KEY_INIT_TRUE;
>>> +DEFINE_STATIC_KEY_TRUE(supports_deactivate_key);
>>
>> ...with that, bad things happen:
>>
>> drivers/irqchip/irq-gic-v3.o:(.data+0x278): multiple definition of `supports_deactivate_key'
>> drivers/irqchip/irq-gic.o:(.data+0x18): first defined here
>> Makefile:1032: recipe for target 'vmlinux' failed
>> make: *** [vmlinux] Error 1
>
> Hmm both were (cross) compile tested, I'll have a look.
Odd. I don't see how you can avoid this failure at link time...
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-03-26 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 19:10 [PATCH -next 0/3] update some static key users " Davidlohr Bueso
2018-03-25 19:10 ` [PATCH 1/3] i2c: update i2c_trace_msg static key " Davidlohr Bueso
2018-03-26 8:33 ` Peter Zijlstra
2018-03-26 8:34 ` Peter Zijlstra
2018-03-25 19:10 ` [PATCH 2/3] drivers/irqchip: update supports_deactivate " Davidlohr Bueso
2018-03-26 8:17 ` Marc Zyngier
2018-03-26 13:54 ` Davidlohr Bueso
2018-03-26 14:24 ` Marc Zyngier [this message]
2018-03-26 19:57 ` Davidlohr Bueso
2018-03-26 8:34 ` Peter Zijlstra
2018-03-26 8:34 ` Peter Zijlstra
2018-03-25 19:10 ` [PATCH 3/3] sched/core: update preempt_notifier_key " Davidlohr Bueso
2018-03-26 8:35 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56064180-053b-2987-d10e-7e5f36c579a1@arm.com \
--to=marc.zyngier@arm.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®