From: Mark Brown <broonie@kernel.org>
To: David Collins <collinsd@codeaurora.org>
Cc: Doug Anderson <dianders@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
sboyd@kernel.org, ilina@codeaurora.org
Subject: Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver
Date: Wed, 28 Mar 2018 10:08:45 +0800 [thread overview]
Message-ID: <20180328020845.GB29099@sirena.org.uk> (raw)
In-Reply-To: <172d1da4-bde0-1f0c-b907-5582c31c8156@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Tue, Mar 27, 2018 at 04:38:07PM -0700, David Collins wrote:
> On 03/27/2018 04:56 AM, Mark Brown wrote:
> > I didn't spot this in the code but something called "device tree mode"
> > sounds like it's going to be awfully confusing...
> As I explained in the earlier email, it makes the device tree
> configurations much simpler and less confusing/error prone. I'd like to
> keep this concept around unless their are strong objections.
Like I say I didn't spot this in the code, I did give it a brief once
over but as Doug had spotted such extensive problems I was expecting a
resend. It *is* setting off big alarm bells though, in general if your
individual driver is doing something weird to make life easier that's a
sign that it's doing things at the wrong level.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-28 2:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 1:09 [PATCH 0/2] " David Collins
2018-03-17 1:09 ` [PATCH 1/2] " David Collins
2018-03-18 20:38 ` [PATCH] regulator: fix platform_no_drv_owner.cocci warnings kbuild test robot
2018-03-19 21:47 ` David Collins
2018-03-18 20:38 ` [PATCH 1/2] regulator: add QCOM RPMh regulator driver kbuild test robot
2018-03-21 2:16 ` Doug Anderson
2018-03-22 22:31 ` David Collins
2018-03-23 20:00 ` Doug Anderson
2018-03-27 11:56 ` Mark Brown
2018-03-27 20:51 ` Doug Anderson
2018-03-28 2:28 ` Mark Brown
2018-03-27 23:38 ` David Collins
2018-03-28 2:08 ` Mark Brown [this message]
2018-03-27 23:22 ` David Collins
2018-03-21 19:07 ` Stephen Boyd
2018-03-23 1:30 ` David Collins
2018-03-26 15:35 ` Lina Iyer
2018-04-19 5:55 ` Stephen Boyd
2018-04-19 12:08 ` Mark Brown
2018-04-20 19:28 ` David Collins
2018-04-24 17:41 ` Mark Brown
2018-04-24 20:46 ` David Collins
2018-05-17 6:09 ` Mark Brown
2018-05-17 20:48 ` David Collins
2018-05-22 16:36 ` Mark Brown
2018-04-20 19:07 ` David Collins
2018-04-20 22:44 ` Lina Iyer
2018-04-24 20:33 ` David Collins
2018-03-29 22:36 ` Doug Anderson
2018-03-17 1:09 ` [PATCH 2/2] dt-bindings: regulator: add QCOM RPMh regulator bindings David Collins
2018-03-21 2:16 ` Doug Anderson
2018-03-21 23:54 ` David Collins
2018-03-21 2:43 ` Mark Brown
2018-03-27 23:48 ` David Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328020845.GB29099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=ilina@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®