From: Nasser Afshin <afshin.nasser@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Nasser Afshin <Afshin.Nasser@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/4] media: i2c: tvp5150: Use the correct comment style
Date: Tue, 3 Apr 2018 02:53:18 +0430 [thread overview]
Message-ID: <20180402222322.30385-3-Afshin.Nasser@gmail.com> (raw)
In-Reply-To: <20180402222322.30385-1-Afshin.Nasser@gmail.com>
This patch resolves checkpatch.pl warnings:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com>
---
drivers/media/i2c/tvp5150.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index af56a5a6db65..fd23138cc6a3 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -502,8 +502,10 @@ struct i2c_vbi_ram_value {
static struct i2c_vbi_ram_value vbi_ram_default[] =
{
- /* FIXME: Current api doesn't handle all VBI types, those not
- yet supported are placed under #if 0 */
+ /*
+ * FIXME: Current api doesn't handle all VBI types, those not
+ * yet supported are placed under #if 0
+ */
#if 0
[0] = {0x010, /* Teletext, SECAM, WST System A */
{V4L2_SLICED_TELETEXT_SECAM, 6, 23, 1},
@@ -1101,11 +1103,14 @@ static int tvp5150_s_routing(struct v4l2_subdev *sd,
static int tvp5150_s_raw_fmt(struct v4l2_subdev *sd, struct v4l2_vbi_format *fmt)
{
- /* this is for capturing 36 raw vbi lines
- if there's a way to cut off the beginning 2 vbi lines
- with the tvp5150 then the vbi line count could be lowered
- to 17 lines/field again, although I couldn't find a register
- which could do that cropping */
+ /*
+ * this is for capturing 36 raw vbi lines
+ * if there's a way to cut off the beginning 2 vbi lines
+ * with the tvp5150 then the vbi line count could be lowered
+ * to 17 lines/field again, although I couldn't find a register
+ * which could do that cropping
+ */
+
if (fmt->sample_format == V4L2_PIX_FMT_GREY)
tvp5150_write(sd, TVP5150_LUMA_PROC_CTL_1, 0x70);
if (fmt->count[0] == 18 && fmt->count[1] == 18) {
--
2.15.0
next prev parent reply other threads:[~2018-04-02 22:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 19:59 [PATCH 0/3] media: i2c: tvp5150: resolve checkpatch errors Nasser Afshin
2018-04-02 19:59 ` [PATCH 1/3] media: i2c: tvp5150: Add a space after commas Nasser Afshin
2018-04-02 19:59 ` [PATCH 2/3] media: i2c: tvp5150: Use the correct comment style Nasser Afshin
2018-04-02 19:59 ` [PATCH 3/3] media: i2c: tvp5150: Use parentheses for sizeof Nasser Afshin
2018-04-02 20:17 ` Gustavo A. R. Silva
2018-04-02 22:23 ` [PATCH v2 0/4] media: i2c: tvp5150: resolve checkpatch errors Nasser Afshin
2018-04-02 22:23 ` [PATCH v2 1/4] media: i2c: tvp5150: Add a space after commas Nasser Afshin
2018-04-02 22:23 ` Nasser Afshin [this message]
2018-04-02 22:23 ` [PATCH v2 3/4] media: i2c: tvp5150: Fix open brace placement codding style Nasser Afshin
2018-04-02 22:23 ` [PATCH v2 4/4] media: i2c: tvp5150: Use parentheses for sizeof Nasser Afshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402222322.30385-3-Afshin.Nasser@gmail.com \
--to=afshin.nasser@gmail.com \
--cc=garsilva@embeddedor.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®