From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Nasser Afshin <afshin.nasser@gmail.com>, mchehab@kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: i2c: tvp5150: Use parentheses for sizeof
Date: Mon, 2 Apr 2018 15:17:37 -0500 [thread overview]
Message-ID: <d5e8dbe4-b68b-ac4e-0076-a3ee995f8327@embeddedor.com> (raw)
In-Reply-To: <20180402195907.14368-4-Afshin.Nasser@gmail.com>
Hi,
On 04/02/2018 02:59 PM, Nasser Afshin wrote:
> This patch resolves a checkpatch.pl warning
It would be nice if you explicitly mention the warning.
Thanks.
--
Gustavo
> Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com>
> ---
> drivers/media/i2c/tvp5150.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index d561d87d219a..d528fddbea16 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -625,7 +625,7 @@ static int tvp5150_g_sliced_vbi_cap(struct v4l2_subdev *sd,
> int line, i;
>
> dev_dbg_lvl(sd->dev, 1, debug, "g_sliced_vbi_cap\n");
> - memset(cap, 0, sizeof *cap);
> + memset(cap, 0, sizeof(*cap));
>
> for (i = 0; i < ARRAY_SIZE(vbi_ram_default); i++) {
> const struct i2c_vbi_ram_value *regs = &vbi_ram_default[i];
next prev parent reply other threads:[~2018-04-02 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 19:59 [PATCH 0/3] media: i2c: tvp5150: resolve checkpatch errors Nasser Afshin
2018-04-02 19:59 ` [PATCH 1/3] media: i2c: tvp5150: Add a space after commas Nasser Afshin
2018-04-02 19:59 ` [PATCH 2/3] media: i2c: tvp5150: Use the correct comment style Nasser Afshin
2018-04-02 19:59 ` [PATCH 3/3] media: i2c: tvp5150: Use parentheses for sizeof Nasser Afshin
2018-04-02 20:17 ` Gustavo A. R. Silva [this message]
2018-04-02 22:23 ` [PATCH v2 0/4] media: i2c: tvp5150: resolve checkpatch errors Nasser Afshin
2018-04-02 22:23 ` [PATCH v2 1/4] media: i2c: tvp5150: Add a space after commas Nasser Afshin
2018-04-02 22:23 ` [PATCH v2 2/4] media: i2c: tvp5150: Use the correct comment style Nasser Afshin
2018-04-02 22:23 ` [PATCH v2 3/4] media: i2c: tvp5150: Fix open brace placement codding style Nasser Afshin
2018-04-02 22:23 ` [PATCH v2 4/4] media: i2c: tvp5150: Use parentheses for sizeof Nasser Afshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5e8dbe4-b68b-ac4e-0076-a3ee995f8327@embeddedor.com \
--to=garsilva@embeddedor.com \
--cc=afshin.nasser@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®