From: kbuild test robot <lkp@intel.com>
To: kpark3469@gmail.com
Cc: kbuild-all@01.org, kernel-hardening@lists.openwall.com,
catalin.marinas@arm.com, keescook@chromium.org,
will.deacon@arm.com, mark.rutland@arm.com, james.morse@arm.com,
panand@redhat.com, keun-o.park@darkmatter.ae,
psodagud@codeaurora.org, jpoimboe@redhat.com, mingo@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] stacktrace: move arch_within_stack_frames from thread_info.h
Date: Tue, 10 Apr 2018 05:03:59 +0800 [thread overview]
Message-ID: <201804100434.9G19I0JA%fengguang.wu@intel.com> (raw)
In-Reply-To: <1523275156-29087-2-git-send-email-kpark3469@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6144 bytes --]
Hi Sahara,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16 next-20180409]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/kpark3469-gmail-com/usercopy-reimplement-arch_within_stack_frames/20180409-221953
config: x86_64-randconfig-s0-04100256 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/gpu//drm/drm_mm.c: In function 'save_stack':
drivers/gpu//drm/drm_mm.c:109:9: error: variable 'trace' has initializer but incomplete type
struct stack_trace trace = {
^~~~~~~~~~~
>> drivers/gpu//drm/drm_mm.c:110:3: error: unknown field 'entries' specified in initializer
.entries = entries,
^
drivers/gpu//drm/drm_mm.c:110:14: warning: excess elements in struct initializer
.entries = entries,
^~~~~~~
drivers/gpu//drm/drm_mm.c:110:14: note: (near initialization for 'trace')
>> drivers/gpu//drm/drm_mm.c:111:3: error: unknown field 'max_entries' specified in initializer
.max_entries = STACKDEPTH,
^
drivers/gpu//drm/drm_mm.c:103:20: warning: excess elements in struct initializer
#define STACKDEPTH 32
^
drivers/gpu//drm/drm_mm.c:111:18: note: in expansion of macro 'STACKDEPTH'
.max_entries = STACKDEPTH,
^~~~~~~~~~
drivers/gpu//drm/drm_mm.c:103:20: note: (near initialization for 'trace')
#define STACKDEPTH 32
^
drivers/gpu//drm/drm_mm.c:111:18: note: in expansion of macro 'STACKDEPTH'
.max_entries = STACKDEPTH,
^~~~~~~~~~
>> drivers/gpu//drm/drm_mm.c:112:3: error: unknown field 'skip' specified in initializer
.skip = 1
^
drivers/gpu//drm/drm_mm.c:112:11: warning: excess elements in struct initializer
.skip = 1
^
drivers/gpu//drm/drm_mm.c:112:11: note: (near initialization for 'trace')
drivers/gpu//drm/drm_mm.c:109:21: error: storage size of 'trace' isn't known
struct stack_trace trace = {
^~~~~
>> drivers/gpu//drm/drm_mm.c:115:2: error: implicit declaration of function 'save_stack_trace' [-Werror=implicit-function-declaration]
save_stack_trace(&trace);
^~~~~~~~~~~~~~~~
drivers/gpu//drm/drm_mm.c:109:21: warning: unused variable 'trace' [-Wunused-variable]
struct stack_trace trace = {
^~~~~
drivers/gpu//drm/drm_mm.c: In function 'show_leaks':
drivers/gpu//drm/drm_mm.c:135:10: error: variable 'trace' has initializer but incomplete type
struct stack_trace trace = {
^~~~~~~~~~~
drivers/gpu//drm/drm_mm.c:136:4: error: unknown field 'entries' specified in initializer
.entries = entries,
^
drivers/gpu//drm/drm_mm.c:136:15: warning: excess elements in struct initializer
.entries = entries,
^~~~~~~
drivers/gpu//drm/drm_mm.c:136:15: note: (near initialization for 'trace')
drivers/gpu//drm/drm_mm.c:137:4: error: unknown field 'max_entries' specified in initializer
.max_entries = STACKDEPTH
^
drivers/gpu//drm/drm_mm.c:103:20: warning: excess elements in struct initializer
#define STACKDEPTH 32
^
drivers/gpu//drm/drm_mm.c:137:19: note: in expansion of macro 'STACKDEPTH'
.max_entries = STACKDEPTH
^~~~~~~~~~
drivers/gpu//drm/drm_mm.c:103:20: note: (near initialization for 'trace')
#define STACKDEPTH 32
^
drivers/gpu//drm/drm_mm.c:137:19: note: in expansion of macro 'STACKDEPTH'
.max_entries = STACKDEPTH
^~~~~~~~~~
drivers/gpu//drm/drm_mm.c:135:22: error: storage size of 'trace' isn't known
struct stack_trace trace = {
^~~~~
drivers/gpu//drm/drm_mm.c:147:3: error: implicit declaration of function 'snprint_stack_trace' [-Werror=implicit-function-declaration]
snprint_stack_trace(buf, BUFSZ, &trace, 0);
^~~~~~~~~~~~~~~~~~~
drivers/gpu//drm/drm_mm.c:135:22: warning: unused variable 'trace' [-Wunused-variable]
struct stack_trace trace = {
^~~~~
cc1: some warnings being treated as errors
vim +/max_entries +111 drivers/gpu//drm/drm_mm.c
5705670d Chris Wilson 2016-10-31 105
5705670d Chris Wilson 2016-10-31 106 static noinline void save_stack(struct drm_mm_node *node)
5705670d Chris Wilson 2016-10-31 107 {
5705670d Chris Wilson 2016-10-31 108 unsigned long entries[STACKDEPTH];
5705670d Chris Wilson 2016-10-31 @109 struct stack_trace trace = {
5705670d Chris Wilson 2016-10-31 @110 .entries = entries,
5705670d Chris Wilson 2016-10-31 @111 .max_entries = STACKDEPTH,
5705670d Chris Wilson 2016-10-31 @112 .skip = 1
5705670d Chris Wilson 2016-10-31 113 };
5705670d Chris Wilson 2016-10-31 114
5705670d Chris Wilson 2016-10-31 @115 save_stack_trace(&trace);
5705670d Chris Wilson 2016-10-31 116 if (trace.nr_entries != 0 &&
5705670d Chris Wilson 2016-10-31 117 trace.entries[trace.nr_entries-1] == ULONG_MAX)
5705670d Chris Wilson 2016-10-31 118 trace.nr_entries--;
5705670d Chris Wilson 2016-10-31 119
5705670d Chris Wilson 2016-10-31 120 /* May be called under spinlock, so avoid sleeping */
5705670d Chris Wilson 2016-10-31 121 node->stack = depot_save_stack(&trace, GFP_NOWAIT);
5705670d Chris Wilson 2016-10-31 122 }
5705670d Chris Wilson 2016-10-31 123
:::::: The code at line 111 was first introduced by commit
:::::: 5705670d0463423337c82d00877989e7df8b169d drm: Track drm_mm allocators and show leaks on shutdown
:::::: TO: Chris Wilson <chris@chris-wilson.co.uk>
:::::: CC: Daniel Vetter <daniel.vetter@ffwll.ch>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34715 bytes --]
prev parent reply other threads:[~2018-04-09 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 11:59 [PATCH v3 0/3] usercopy: reimplement arch_within_stack_frames kpark3469
2018-04-09 11:59 ` [PATCH v3 1/3] stacktrace: move arch_within_stack_frames from thread_info.h kpark3469
2018-04-09 11:59 ` [PATCH v3 2/3] arm64: usercopy: implement arch_within_stack_frames kpark3469
2018-04-09 11:59 ` [PATCH v3 3/3] x86: usercopy: reimplement arch_within_stack_frames with unwinder kpark3469
2018-04-09 13:14 ` David Laight
2018-04-10 15:35 ` Josh Poimboeuf
2018-04-09 21:03 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201804100434.9G19I0JA%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jpoimboe@redhat.com \
--cc=kbuild-all@01.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=keun-o.park@darkmatter.ae \
--cc=kpark3469@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=panand@redhat.com \
--cc=psodagud@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®