From: David Laight <David.Laight@ACULAB.COM>
To: "'kpark3469@gmail.com'" <kpark3469@gmail.com>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Cc: "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"panand@redhat.com" <panand@redhat.com>,
"keun-o.park@darkmatter.ae" <keun-o.park@darkmatter.ae>,
"psodagud@codeaurora.org" <psodagud@codeaurora.org>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 3/3] x86: usercopy: reimplement arch_within_stack_frames with unwinder
Date: Mon, 9 Apr 2018 13:14:58 +0000 [thread overview]
Message-ID: <a59b818d84b74c13a4f25f757eba1f93@AcuMS.aculab.com> (raw)
In-Reply-To: <1523275156-29087-4-git-send-email-kpark3469@gmail.com>
From: kpark3469@gmail.com
> Sent: 09 April 2018 12:59
>
> The old arch_within_stack_frames which used the frame pointer is
> now reimplemented to use frame pointer unwinder apis. So the main
> functionality is same as before.
How much slower does this make the code?
Following stack frames using %bp is reasonably quick.
I can't imagine some of the other unwinder APIs being any where
near that fast.
While fine for fault tracebacks, using them during usercopy
is likely to have measurable performance impact.
David
next prev parent reply other threads:[~2018-04-09 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 11:59 [PATCH v3 0/3] usercopy: reimplement arch_within_stack_frames kpark3469
2018-04-09 11:59 ` [PATCH v3 1/3] stacktrace: move arch_within_stack_frames from thread_info.h kpark3469
2018-04-09 11:59 ` [PATCH v3 2/3] arm64: usercopy: implement arch_within_stack_frames kpark3469
2018-04-09 11:59 ` [PATCH v3 3/3] x86: usercopy: reimplement arch_within_stack_frames with unwinder kpark3469
2018-04-09 13:14 ` David Laight [this message]
2018-04-10 15:35 ` Josh Poimboeuf
2018-04-09 21:03 ` [PATCH v3 1/3] stacktrace: move arch_within_stack_frames from thread_info.h kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a59b818d84b74c13a4f25f757eba1f93@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=keun-o.park@darkmatter.ae \
--cc=kpark3469@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=panand@redhat.com \
--cc=psodagud@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®