From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Adam.Thomson.Opensource@diasemi.com,
Jia-Ju Bai <baijiaju1990@gmail.com>,
lgirdwood@gmail.com, sathyanarayana.nujella@intel.com,
perex@perex.cz, alsa-devel@alsa-project.org,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe
Date: Tue, 10 Apr 2018 15:02:51 +0100 [thread overview]
Message-ID: <20180410140251.GB14657@sirena.org.uk> (raw)
In-Reply-To: <s5h3704dvad.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
On Mon, Apr 09, 2018 at 09:39:06PM +0200, Takashi Iwai wrote:
> It must be sleepable context as it's a standard platform driver probe
> callback.
> And now looking at grep output, only sound/soc/intel contains so many
> calls with GFP_ATOMIC. I bet that almost all can be done with
> GFP_KERNEL, maybe only one or two in atom/sst would be conditionally
> with GFP_ATOMIC.
Yeah, it's not like it'd be the first code quality problem found in the
Intel drivers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-04-10 14:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 10:46 Jia-Ju Bai
2018-04-09 18:57 ` [alsa-devel] " Pierre-Louis Bossart
2018-04-09 19:39 ` Takashi Iwai
2018-04-10 14:02 ` Mark Brown [this message]
2018-04-10 14:17 ` Vinod Koul
2018-04-13 10:41 ` Mark Brown
2018-04-13 10:54 ` Jia-Ju Bai
2018-04-13 10:55 ` Mark Brown
2018-04-13 10:56 ` Applied "ASoC: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe" to the asoc tree Mark Brown
2018-04-13 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410140251.GB14657@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=baijiaju1990@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®