From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
sathyanarayana.nujella@intel.com,
Adam.Thomson.Opensource@diasemi.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe
Date: Fri, 13 Apr 2018 18:54:15 +0800 [thread overview]
Message-ID: <32138b5e-843b-3f37-28ee-62d7fa93f0db@gmail.com> (raw)
In-Reply-To: <20180413104130.GA6854@sirena.org.uk>
On 2018/4/13 18:41, Mark Brown wrote:
> On Mon, Apr 09, 2018 at 06:46:21PM +0800, Jia-Ju Bai wrote:
>> broxton_audio_probe() is never called in atomic context.
>> This function is only set as ".probe" in "struct platform_driver".
> Please submit patches using subject lines reflecting the style for the
> subsystem. This makes it easier for people to identify relevant
> patches. Look at what existing commits in the area you're changing are
> doing and make sure your subject lines visually resemble what they're
> doing.
Oh, sorry for my improper subjects.
Thanks for your very helpful advice :)
I looked at previous related patches, and find the subject should be
"ASoC: Intel: ...."
I will follow it in my future patches.
Do I need to send V2 patches?
Best wishes,
Jia-Ju Bai
next prev parent reply other threads:[~2018-04-13 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 10:46 Jia-Ju Bai
2018-04-09 18:57 ` [alsa-devel] " Pierre-Louis Bossart
2018-04-09 19:39 ` Takashi Iwai
2018-04-10 14:02 ` Mark Brown
2018-04-10 14:17 ` Vinod Koul
2018-04-13 10:41 ` Mark Brown
2018-04-13 10:54 ` Jia-Ju Bai [this message]
2018-04-13 10:55 ` Mark Brown
2018-04-13 10:56 ` Applied "ASoC: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe" to the asoc tree Mark Brown
2018-04-13 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32138b5e-843b-3f37-28ee-62d7fa93f0db@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome