From: Ingo Molnar <mingo@kernel.org>
To: Song Liu <songliubraving@fb.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: perf: fuzzer leads to trace_kprobe: Could not insert message flood
Date: Wed, 11 Apr 2018 14:04:47 +0200 [thread overview]
Message-ID: <20180411120447.2gzrwijrtayjv3eg@gmail.com> (raw)
In-Reply-To: <A3B3905F-3364-462A-BE02-B01D52482791@fb.com>
* Song Liu <songliubraving@fb.com> wrote:
>
>
> > On Apr 10, 2018, at 7:48 AM, Vince Weaver <vincent.weaver@maine.edu> wrote:
> >
> > Author: Song Liu <songliubraving@fb.com>
> > Date: Wed Dec 6 14:45:15 2017 -0800
> >
> > When running the perf_fuzzer on a current git checkout my logs are flooded
> > with messages such as this:
> > [71487.869077] trace_kprobe: Could not insert probe at unknown+0: -22
> > [71488.174479] trace_kprobe: Could not insert probe at unknown+0: -22
> >
> > Presumably this is due to the introduction of the perf_kprobe PMU in
> > commit e12f03d7031a977356e3d7b75a68c2185ff8d155
> > Author: Song Liu <songliubraving@fb.com>
> > Date: Wed Dec 6 14:45:15 2017 -0800
> >
> > Is there a way to get this error disabled, or else rate-limited?
> >
> > Vince
>
> Hi Vince,
>
> Thanks for the report.
>
> This is a new API that creates probe together with perf_event_open(). Based on
> my limited understanding of perf_fuzzer, it doesn't understand this API, and uses
> it in an abnormal way. [...]
Vince's point is valid: the kernel log should not be flooded with pointless
messages as a response to user-space ABI uses ...
Why is there a kernel log message at all, isn't an error returned?
> [...] I would recommend perf_fuzzer to understand this new API and test it.
> [...]
This bug needs to be fixed: a new API must not effectively DoS fuzzing efforts by
spamming the kernel log ...
Thanks,
Ingo
next prev parent reply other threads:[~2018-04-11 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 14:48 Vince Weaver
2018-04-10 19:57 ` Song Liu
2018-04-11 12:04 ` Ingo Molnar [this message]
2018-04-11 18:02 ` Song Liu
2018-04-12 7:52 ` Ingo Molnar
2018-04-12 7:53 ` Ingo Molnar
2018-04-12 9:22 ` [tip:perf/urgent] perf/core: Need CAP_SYS_ADMIN to create k/uprobe with perf_event_open() tip-bot for Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411120447.2gzrwijrtayjv3eg@gmail.com \
--to=mingo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome