mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Song Liu <songliubraving@fb.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: perf: fuzzer leads to trace_kprobe: Could not insert message flood
Date: Thu, 12 Apr 2018 09:53:38 +0200	[thread overview]
Message-ID: <20180412075338.tsu36qh2wcrcp36k@gmail.com> (raw)
In-Reply-To: <C0B2EFB5-C403-4BDB-9046-C14B3EE66999@fb.com>


* Song Liu <songliubraving@fb.com> wrote:

> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index d7af828..2d5fe26 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -8400,6 +8400,10 @@ static int perf_kprobe_event_init(struct perf_event *event)
> 
>         if (event->attr.type != perf_kprobe.type)
>                 return -ENOENT;
> +
> +       if (!capable(CAP_SYS_ADMIN))
> +               return -EACCES;
> +
>         /*
>          * no branch sampling for probe events
>          */
> @@ -8437,6 +8441,10 @@ static int perf_uprobe_event_init(struct perf_event *event)
> 
>         if (event->attr.type != perf_uprobe.type)
>                 return -ENOENT;
> +
> +       if (!capable(CAP_SYS_ADMIN))
> +               return -EACCES;

This is seriously whitespace damaged: all tabs are spaces ...

Thanks,

	Ingo

  parent reply	other threads:[~2018-04-12  7:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 14:48 Vince Weaver
2018-04-10 19:57 ` Song Liu
2018-04-11 12:04   ` Ingo Molnar
2018-04-11 18:02     ` Song Liu
2018-04-12  7:52       ` Ingo Molnar
2018-04-12  7:53       ` Ingo Molnar [this message]
2018-04-12  9:22       ` [tip:perf/urgent] perf/core: Need CAP_SYS_ADMIN to create k/uprobe with perf_event_open() tip-bot for Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180412075338.tsu36qh2wcrcp36k@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=songliubraving@fb.com \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome