From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
rjw@rjwysocki.net, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, Morten.Rasmussen@arm.com,
viresh.kumar@linaro.org, valentin.schneider@arm.com
Subject: Re: [PATCH 2/4 v4] sched/rt: add rt_rq utilization tracking
Date: Sat, 14 Apr 2018 12:05:15 +0200 [thread overview]
Message-ID: <20180414100515.GV4064@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1521199541-15308-3-git-send-email-vincent.guittot@linaro.org>
On Fri, Mar 16, 2018 at 12:25:39PM +0100, Vincent Guittot wrote:
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 783eacf..a8003a9 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -592,6 +592,8 @@ struct rt_rq {
> unsigned long rt_nr_total;
> int overloaded;
> struct plist_head pushable_tasks;
> +
> + struct sched_avg avg;
We only want this for the root cgroup, right? So why is this per cgroup?
That is, I was expecting it to be rq::rt_avg or something.
next prev parent reply other threads:[~2018-04-14 10:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 11:25 [PATCH 0/4 v4] sched/rt: track rt rq utilization Vincent Guittot
2018-03-16 11:25 ` [PATCH 1/4 v4] sched/pelt: Move pelt related code in a dedicated file Vincent Guittot
2018-04-15 11:58 ` Dietmar Eggemann
2018-04-15 12:16 ` Vincent Guittot
2018-04-15 13:27 ` Dietmar Eggemann
2018-04-15 11:58 ` Dietmar Eggemann
2018-03-16 11:25 ` [PATCH 2/4 v4] sched/rt: add rt_rq utilization tracking Vincent Guittot
2018-04-14 10:05 ` Peter Zijlstra [this message]
2018-04-14 11:29 ` Vincent Guittot
2018-03-16 11:25 ` [PATCH 3/4 v4] cpufreq/schedutil: add rt " Vincent Guittot
2018-03-16 11:25 ` [PATCH 4/4 v4] sched/nohz: monitor rt utilization Vincent Guittot
2018-04-14 10:07 ` [PATCH 0/4 v4] sched/rt: track rt rq utilization Peter Zijlstra
2018-04-14 11:42 ` Vincent Guittot
2018-04-15 11:56 ` Dietmar Eggemann
2018-04-15 12:00 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180414100515.GV4064@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Morten.Rasmussen@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome