From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, rjw@rjwysocki.net
Cc: juri.lelli@redhat.com, Morten.Rasmussen@arm.com,
viresh.kumar@linaro.org, valentin.schneider@arm.com
Subject: Re: [PATCH 1/4 v4] sched/pelt: Move pelt related code in a dedicated file
Date: Sun, 15 Apr 2018 13:58:41 +0200 [thread overview]
Message-ID: <8f70e4de-e603-147f-8c9e-5b20e0e49ec1@arm.com> (raw)
In-Reply-To: <1521199541-15308-2-git-send-email-vincent.guittot@linaro.org>
On 03/16/2018 12:25 PM, Vincent Guittot wrote:
[...]
> diff --git a/kernel/sched/pelt.h b/kernel/sched/pelt.h
> new file mode 100644
> index 0000000..c312d8c
> --- /dev/null
> +++ b/kernel/sched/pelt.h
> @@ -0,0 +1,17 @@
> +#ifdef CONFIG_SMP
> +
> +int __update_load_avg_blocked_se(u64 now, int cpu, struct sched_entity *se);
> +int __update_load_avg_se(u64 now, int cpu, struct cfs_rq *cfs_rq, struct sched_entity *se);
> +int __update_load_avg_cfs_rq(u64 now, int cpu, struct cfs_rq *cfs_rq);
> +
> +#else
> +
> +static inline int
> +update_cfs_rq_load_avg(u64 now, struct cfs_rq *cfs_rq)
> +{
> + return 0;
> +}
> +
> +#endif
Exporting __update_load_avg_cfs_rq() for SMP and
update_cfs_rq_load_avg() for !SMP seems weird.
[...]
next prev parent reply other threads:[~2018-04-15 11:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 11:25 [PATCH 0/4 v4] sched/rt: track rt rq utilization Vincent Guittot
2018-03-16 11:25 ` [PATCH 1/4 v4] sched/pelt: Move pelt related code in a dedicated file Vincent Guittot
2018-04-15 11:58 ` Dietmar Eggemann
2018-04-15 12:16 ` Vincent Guittot
2018-04-15 13:27 ` Dietmar Eggemann
2018-04-15 11:58 ` Dietmar Eggemann [this message]
2018-03-16 11:25 ` [PATCH 2/4 v4] sched/rt: add rt_rq utilization tracking Vincent Guittot
2018-04-14 10:05 ` Peter Zijlstra
2018-04-14 11:29 ` Vincent Guittot
2018-03-16 11:25 ` [PATCH 3/4 v4] cpufreq/schedutil: add rt " Vincent Guittot
2018-03-16 11:25 ` [PATCH 4/4 v4] sched/nohz: monitor rt utilization Vincent Guittot
2018-04-14 10:07 ` [PATCH 0/4 v4] sched/rt: track rt rq utilization Peter Zijlstra
2018-04-14 11:42 ` Vincent Guittot
2018-04-15 11:56 ` Dietmar Eggemann
2018-04-15 12:00 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f70e4de-e603-147f-8c9e-5b20e0e49ec1@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=Morten.Rasmussen@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome