From: Christoph Hellwig <hch@infradead.org>
To: Mark Brown <broonie@kernel.org>
Cc: Peter Rosin <peda@axentia.se>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 3/5] ASoC: max9860: switch to SPDX license tag
Date: Sun, 15 Apr 2018 00:32:29 -0700 [thread overview]
Message-ID: <20180415073229.GA19823@infradead.org> (raw)
In-Reply-To: <20180413111927.GC6854@sirena.org.uk>
On Fri, Apr 13, 2018 at 12:19:27PM +0100, Mark Brown wrote:
> On Thu, Apr 12, 2018 at 11:14:35PM +0200, Peter Rosin wrote:
>
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > /*
> > * Driver for the MAX9860 Mono Audio Voice Codec
> > *
>
> Please don't mix C and C++ comments like this - it looks unintentional
> and messy. Just convert the entire comment block to C++ so it's
> consistent with itself.
NAK - that is exactky the wrong way to go. Normal Linux comments are
classi C-style comments and should remain so. SPDX tags use c++
comments exactly to be different and stick out.
---end quoted text---
next prev parent reply other threads:[~2018-04-15 7:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 12:42 [PATCH 1/2] ASoC: max9860: switch to using .probe_new Peter Rosin
2018-04-11 12:42 ` [PATCH 2/2] ASoC: tfa9879: " Peter Rosin
2018-04-12 16:16 ` Mark Brown
2018-04-12 21:14 ` Peter Rosin
2018-04-12 21:14 ` [PATCH v2 1/5] ASoC: max9860: fix whitespace issues caused by mindless conversion Peter Rosin
2018-04-13 11:23 ` Applied "ASoC: max9860: fix whitespace issues caused by mindless conversion" to the asoc tree Mark Brown
2018-04-12 21:14 ` [PATCH v2 2/5] ASoC: tfa9879: fix whitespace issues caused by mindless conversion Peter Rosin
2018-04-13 11:22 ` Applied "ASoC: tfa9879: fix whitespace issues caused by mindless conversion" to the asoc tree Mark Brown
2018-04-16 11:40 ` Mark Brown
2018-04-12 21:14 ` [PATCH v2 3/5] ASoC: max9860: switch to SPDX license tag Peter Rosin
2018-04-13 11:19 ` Mark Brown
2018-04-13 11:47 ` [PATCH v3 0/2] ASoC: max9860/tfa9879: " Peter Rosin
2018-04-13 11:47 ` [PATCH v3 1/2] ASoC: max9860: " Peter Rosin
2018-04-16 11:39 ` Applied "ASoC: max9860: switch to SPDX license tag" to the asoc tree Mark Brown
2018-04-16 11:59 ` Mark Brown
2018-04-13 11:47 ` [PATCH v3 2/2] ASoC: tfa9879: switch to SPDX license tag Peter Rosin
2018-04-13 13:43 ` Applied "ASoC: tfa9879: switch to SPDX license tag" to the asoc tree Mark Brown
2018-04-16 11:39 ` Mark Brown
2018-04-16 12:00 ` Mark Brown
2018-04-13 13:41 ` [PATCH v3 0/2] ASoC: max9860/tfa9879: switch to SPDX license tag Mark Brown
2018-04-15 7:32 ` Christoph Hellwig [this message]
2018-04-16 11:35 ` [PATCH v2 3/5] ASoC: max9860: " Mark Brown
2018-04-12 21:14 ` [PATCH v2 4/5] ASoC: tfa9879: " Peter Rosin
2018-04-12 21:14 ` [PATCH v2 5/5] ASoC: tfa9879: switch to using .probe_new Peter Rosin
2018-04-13 11:22 ` Applied "ASoC: tfa9879: switch to using .probe_new" to the asoc tree Mark Brown
2018-04-16 11:40 ` Mark Brown
2018-04-13 11:21 ` [PATCH 2/2] ASoC: tfa9879: switch to using .probe_new Mark Brown
2018-04-12 16:16 ` Applied "ASoC: max9860: switch to using .probe_new" to the asoc tree Mark Brown
2018-04-13 10:56 ` Mark Brown
2018-04-13 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180415073229.GA19823@infradead.org \
--to=hch@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®