mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Romain Izard <romain.izard.pro@gmail.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] usb: gadget: udc: atmel: Fix indenting
Date: Mon, 16 Apr 2018 13:44:27 +0200	[thread overview]
Message-ID: <20180416114427.GE2750@rfolt0960.corp.atmel.com> (raw)
In-Reply-To: <20180416093405.16612-4-romain.izard.pro@gmail.com>

On Mon, Apr 16, 2018 at 11:34:05AM +0200, Romain Izard wrote:
> Fix the fallout of the conversion to GPIO descriptors in 3df034081021.
> 
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index b9623e228609..2f586f2bda7e 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -2277,15 +2277,15 @@ static int usba_udc_probe(struct platform_device *pdev)
>  	if (udc->vbus_pin) {
>  		irq_set_status_flags(gpiod_to_irq(udc->vbus_pin), IRQ_NOAUTOEN);
>  		ret = devm_request_threaded_irq(&pdev->dev,
> -					gpiod_to_irq(udc->vbus_pin), NULL,
> -					usba_vbus_irq_thread, USBA_VBUS_IRQFLAGS,
> -					"atmel_usba_udc", udc);
> -			if (ret) {
> -				udc->vbus_pin = NULL;
> -				dev_warn(&udc->pdev->dev,
> -					 "failed to request vbus irq; "
> -					 "assuming always on\n");
> -			}
> +				gpiod_to_irq(udc->vbus_pin), NULL,
> +				usba_vbus_irq_thread, USBA_VBUS_IRQFLAGS,
> +				"atmel_usba_udc", udc);
> +		if (ret) {
> +			udc->vbus_pin = NULL;
> +			dev_warn(&udc->pdev->dev,
> +				 "failed to request vbus irq; "
> +				 "assuming always on\n");
> +		}
>  	}
>  
>  	ret = usb_add_gadget_udc(&pdev->dev, &udc->gadget);
> -- 
> 2.14.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-04-16 11:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16  9:34 [PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1 Romain Izard
2018-04-16  9:34 ` [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod Romain Izard
2018-04-16 11:42   ` Ludovic Desroches
2018-04-25  9:53   ` Felipe Balbi
2018-04-16  9:34 ` [PATCH 2/3] usb: gadget: udc: atmel: Remove obsolete include Romain Izard
2018-04-16 11:44   ` Ludovic Desroches
2018-04-16  9:34 ` [PATCH 3/3] usb: gadget: udc: atmel: Fix indenting Romain Izard
2018-04-16 11:44   ` Ludovic Desroches [this message]
2018-04-17  8:24 ` [PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1 Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416114427.GE2750@rfolt0960.corp.atmel.com \
    --to=ludovic.desroches@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=romain.izard.pro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®