From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Romain Izard <romain.izard.pro@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>
Subject: Re: [PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1
Date: Tue, 17 Apr 2018 10:24:06 +0200 [thread overview]
Message-ID: <cbdab54a-d01a-2668-c3bc-b5b334a555e0@microchip.com> (raw)
In-Reply-To: <20180416093405.16612-1-romain.izard.pro@gmail.com>
On 16/04/2018 at 11:34, Romain Izard wrote:
> The use of GPIO descriptors takes care of inversion flags declared in
> the device tree. The conversion of the Atmel USBA UDC driver introduced
> in 4.17-rc1 missed it, and as a result the inversion will not work.
>
> In addition, cleanup the code to remove an include left behind after
> the suppression of the support of platform_data to declare USBA
> controllers.
>
> These changes have not been tested on any hardware, as I do not have
> a board that needs to use inverted GPIOs.
>
> Romain Izard (3):
> usb: gadget: udc: atmel: GPIO inversion is handled by gpiod
> usb: gadget: udc: atmel: Remove obsolete include
> usb: gadget: udc: atmel: Fix indenting
To the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thank you Romain.
Best regards,
Nicolas
>
> drivers/usb/gadget/udc/atmel_usba_udc.c | 22 ++++++++++------------
> drivers/usb/gadget/udc/atmel_usba_udc.h | 1 -
> include/linux/usb/atmel_usba_udc.h | 24 ------------------------
> 3 files changed, 10 insertions(+), 37 deletions(-)
> delete mode 100644 include/linux/usb/atmel_usba_udc.h
>
--
Nicolas Ferre
prev parent reply other threads:[~2018-04-17 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 9:34 Romain Izard
2018-04-16 9:34 ` [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod Romain Izard
2018-04-16 11:42 ` Ludovic Desroches
2018-04-25 9:53 ` Felipe Balbi
2018-04-16 9:34 ` [PATCH 2/3] usb: gadget: udc: atmel: Remove obsolete include Romain Izard
2018-04-16 11:44 ` Ludovic Desroches
2018-04-16 9:34 ` [PATCH 3/3] usb: gadget: udc: atmel: Fix indenting Romain Izard
2018-04-16 11:44 ` Ludovic Desroches
2018-04-17 8:24 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbdab54a-d01a-2668-c3bc-b5b334a555e0@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=romain.izard.pro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®