mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] hsi: clients: Change return type to vm_fault_t
@ 2018-04-17 13:57 Souptick Joarder
  2018-04-17 14:07 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2018-04-17 13:57 UTC (permalink / raw)
  To: sre, viro, arnd; +Cc: linux-kernel, willy

Use new return type vm_fault_t for fault handler. For
now, this is just documenting that the function returns
a VM_FAULT value rather than an errno. Once all instances
are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to
vm_fault_t")

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/hsi/clients/cmt_speech.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c
index 324cb8e..a1d4b93 100644
--- a/drivers/hsi/clients/cmt_speech.c
+++ b/drivers/hsi/clients/cmt_speech.c
@@ -1098,7 +1098,7 @@ static void cs_hsi_stop(struct cs_hsi_iface *hi)
 	kfree(hi);
 }

-static int cs_char_vma_fault(struct vm_fault *vmf)
+static vm_fault_t cs_char_vma_fault(struct vm_fault *vmf)
 {
 	struct cs_char *csdata = vmf->vma->vm_private_data;
 	struct page *page;
--
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] hsi: clients: Change return type to vm_fault_t
  2018-04-17 13:57 [PATCH] hsi: clients: Change return type to vm_fault_t Souptick Joarder
@ 2018-04-17 14:07 ` Sebastian Reichel
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2018-04-17 14:07 UTC (permalink / raw)
  To: Souptick Joarder; +Cc: viro, arnd, linux-kernel, willy

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Hi,

On Tue, Apr 17, 2018 at 07:27:42PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
> 
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  drivers/hsi/clients/cmt_speech.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c
> index 324cb8e..a1d4b93 100644
> --- a/drivers/hsi/clients/cmt_speech.c
> +++ b/drivers/hsi/clients/cmt_speech.c
> @@ -1098,7 +1098,7 @@ static void cs_hsi_stop(struct cs_hsi_iface *hi)
>  	kfree(hi);
>  }
> 
> -static int cs_char_vma_fault(struct vm_fault *vmf)
> +static vm_fault_t cs_char_vma_fault(struct vm_fault *vmf)
>  {
>  	struct cs_char *csdata = vmf->vma->vm_private_data;
>  	struct page *page;
> --
> 1.9.1
> 

Thanks, queued to hsi-next.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-17 14:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 13:57 [PATCH] hsi: clients: Change return type to vm_fault_t Souptick Joarder
2018-04-17 14:07 ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®