* [PATCH][next] spi: pxa2xx: make function pxa2xx_spi_transfer_one static
@ 2018-04-18 16:18 Colin King
2018-04-18 16:23 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-04-18 16:18 UTC (permalink / raw)
To: Daniel Mack, Haojian Zhuang, Robert Jarzmik, Mark Brown,
linux-arm-kernel, linux-spi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function pxa2xx_spi_transfer_one is local to the source and
do not need to be in global scope, so make it static.
Cleans up sparse warning:
drivers/spi/spi-pxa2xx.c:914:5: warning: symbol 'pxa2xx_spi_transfer_one'
was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/spi/spi-pxa2xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index c852ea5c28c6..40f1346b8188 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -911,9 +911,9 @@ static bool pxa2xx_spi_can_dma(struct spi_controller *master,
xfer->len >= chip->dma_burst_size;
}
-int pxa2xx_spi_transfer_one(struct spi_controller *master,
- struct spi_device *spi,
- struct spi_transfer *transfer)
+static int pxa2xx_spi_transfer_one(struct spi_controller *master,
+ struct spi_device *spi,
+ struct spi_transfer *transfer)
{
struct driver_data *drv_data = spi_controller_get_devdata(master);
struct spi_message *message = master->cur_msg;
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][next] spi: pxa2xx: make function pxa2xx_spi_transfer_one static
2018-04-18 16:18 [PATCH][next] spi: pxa2xx: make function pxa2xx_spi_transfer_one static Colin King
@ 2018-04-18 16:23 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2018-04-18 16:23 UTC (permalink / raw)
To: Colin King
Cc: Daniel Mack, Haojian Zhuang, Robert Jarzmik, linux-arm-kernel,
linux-spi, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Wed, Apr 18, 2018 at 05:18:42PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function pxa2xx_spi_transfer_one is local to the source and
> do not need to be in global scope, so make it static.
Someone already sent a patch for this which I applied earlier today.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-18 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-18 16:18 [PATCH][next] spi: pxa2xx: make function pxa2xx_spi_transfer_one static Colin King
2018-04-18 16:23 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®