* [PATCH v2] media: v4l2-core: videobuf-dma-sg: Change return type to vm_fault_t
@ 2018-04-18 18:19 Souptick Joarder
2018-04-18 18:36 ` Matthew Wilcox
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2018-04-18 18:19 UTC (permalink / raw)
To: sakari.ailus, mchehab, jack, dan.j.williams, akpm
Cc: linux-media, linux-kernel, willy
Use new return type vm_fault_t for fault handler. For
now, this is just documenting that the function returns
a VM_FAULT value rather than an errno. Once all instances
are converted, vm_fault_t will become a distinct type.
Reference id -> 1c8f422059ae ("mm: change return type to
vm_fault_t")
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
v2: Updated patch subject
drivers/media/v4l2-core/videobuf-dma-sg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf-dma-sg.c b/drivers/media/v4l2-core/videobuf-dma-sg.c
index f412429..54257ea 100644
--- a/drivers/media/v4l2-core/videobuf-dma-sg.c
+++ b/drivers/media/v4l2-core/videobuf-dma-sg.c
@@ -435,7 +435,7 @@ static void videobuf_vm_close(struct vm_area_struct *vma)
* now ...). Bounce buffers don't work very well for the data rates
* video capture has.
*/
-static int videobuf_vm_fault(struct vm_fault *vmf)
+static vm_fault_t videobuf_vm_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct page *page;
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] media: v4l2-core: videobuf-dma-sg: Change return type to vm_fault_t
2018-04-18 18:19 [PATCH v2] media: v4l2-core: videobuf-dma-sg: Change return type to vm_fault_t Souptick Joarder
@ 2018-04-18 18:36 ` Matthew Wilcox
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2018-04-18 18:36 UTC (permalink / raw)
To: Souptick Joarder
Cc: sakari.ailus, mchehab, jack, dan.j.williams, akpm, linux-media,
linux-kernel
On Wed, Apr 18, 2018 at 11:49:19PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> v2: Updated patch subject
I'm pretty sure what Sakari meant was:
videobuf: Change return type to vm_fault_t
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-18 18:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-18 18:19 [PATCH v2] media: v4l2-core: videobuf-dma-sg: Change return type to vm_fault_t Souptick Joarder
2018-04-18 18:36 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®