From: Guenter Roeck <linux@roeck-us.net>
To: Jerry Hoemann <jerry.hoemann@hpe.com>
Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] watchdog: hpwdt: Claim NMIs generated by iLO5
Date: Thu, 3 May 2018 14:20:33 -0700 [thread overview]
Message-ID: <20180503212033.GA32321@roeck-us.net> (raw)
In-Reply-To: <20180503210055.32483-2-jerry.hoemann@hpe.com>
On Thu, May 03, 2018 at 03:00:55PM -0600, Jerry Hoemann wrote:
> On iLO5 going forward we want to return and not claim the NMI, if
> the NMI was NOT gnerated by the iLO as a result of the watchdog
> timing out or an explicit generate NMI.
>
> The sense of the test in is inverted and prevents hpwdt_pretimeout
> from claiming NMIs when it should.
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Fixes: a042229a18ac ("watchdog: hpwdt: Update nmi_panic message.")
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/hpwdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index a43ab2cecca2..9dc62a461451 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -159,7 +159,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
> "3. OA Forward Progress Log\n"
> "4. iLO Event Log";
>
> - if (ilo5 && ulReason == NMI_UNKNOWN && mynmi)
> + if (ilo5 && ulReason == NMI_UNKNOWN && !mynmi)
> return NMI_DONE;
>
> if (ilo5 && !pretimeout)
> --
> 2.13.6
>
prev parent reply other threads:[~2018-05-03 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 21:00 [PATCH 0/1] watchdog/hpwdt: " Jerry Hoemann
2018-05-03 21:00 ` [PATCH 1/1] watchdog: hpwdt: " Jerry Hoemann
2018-05-03 21:20 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503212033.GA32321@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®