[PATCH v1] lib/string_helpers: Add missed declaration of struct task_struct

[PATCH v1] lib/string_helpers: Add missed declaration of struct task_struct

[Andy Shevchenko]

Starting from the commit 0d0443288f22 the new function has been
introduced which takes struct task_struct as a parameter. Though,
compiler doesn't know where to get information about it at this stage.

Add missed declaration of struct task_struct to satisfy compiler.

Fixes: 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")
Cc: Kees Cook <keescook@chromium.org>
Cc: James Morris <james.l.morris@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/string_helpers.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
index 4397c52ec4a4..d23c5030901a 100644
--- a/include/linux/string_helpers.h
+++ b/include/linux/string_helpers.h
@@ -5,6 +5,7 @@
 #include <linux/types.h>
 
 struct file;
+struct task_struct;
 
 /* Descriptions of the types of units to
  * print in */
-- 
2.17.0

Re: [PATCH v1] lib/string_helpers: Add missed declaration of struct task_struct

[Kees Cook]

On Thu, May 3, 2018 at 6:13 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Starting from the commit 0d0443288f22 the new function has been
> introduced which takes struct task_struct as a parameter. Though,
> compiler doesn't know where to get information about it at this stage.
>
> Add missed declaration of struct task_struct to satisfy compiler.
>
> Fixes: 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")
> Cc: Kees Cook <keescook@chromium.org>
> Cc: James Morris <james.l.morris@oracle.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Kees Cook <keescook@chromium.org>

I'm not sure who should carry this. You're welcome to put it in your tree?

-Kees

> ---
>  include/linux/string_helpers.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
> index 4397c52ec4a4..d23c5030901a 100644
> --- a/include/linux/string_helpers.h
> +++ b/include/linux/string_helpers.h
> @@ -5,6 +5,7 @@
>  #include <linux/types.h>
>
>  struct file;
> +struct task_struct;
>
>  /* Descriptions of the types of units to
>   * print in */
> --
> 2.17.0
>



-- 
Kees Cook
Pixel Security

Re: [PATCH v1] lib/string_helpers: Add missed declaration of struct task_struct

[Kees Cook]

On Thu, May 3, 2018 at 9:34 PM, Kees Cook <keescook@chromium.org> wrote:
> On Thu, May 3, 2018 at 6:13 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>> Starting from the commit 0d0443288f22 the new function has been
>> introduced which takes struct task_struct as a parameter. Though,
>> compiler doesn't know where to get information about it at this stage.
>>
>> Add missed declaration of struct task_struct to satisfy compiler.
>>
>> Fixes: 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")
>> Cc: Kees Cook <keescook@chromium.org>
>> Cc: James Morris <james.l.morris@oracle.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> I'm not sure who should carry this. You're welcome to put it in your tree?

I haven't seen this show up in linux-next. Andy will you be taking it?

-Kees

>
> -Kees
>
>> ---
>>  include/linux/string_helpers.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
>> index 4397c52ec4a4..d23c5030901a 100644
>> --- a/include/linux/string_helpers.h
>> +++ b/include/linux/string_helpers.h
>> @@ -5,6 +5,7 @@
>>  #include <linux/types.h>
>>
>>  struct file;
>> +struct task_struct;
>>
>>  /* Descriptions of the types of units to
>>   * print in */
>> --
>> 2.17.0
>>
>
>
>
> --
> Kees Cook
> Pixel Security



-- 
Kees Cook
Pixel Security

Re: [PATCH v1] lib/string_helpers: Add missed declaration of struct task_struct

[Andy Shevchenko]

On Thu, May 10, 2018 at 11:59 PM, Kees Cook <keescook@chromium.org> wrote:
> On Thu, May 3, 2018 at 9:34 PM, Kees Cook <keescook@chromium.org> wrote:
>> On Thu, May 3, 2018 at 6:13 PM, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>> Starting from the commit 0d0443288f22 the new function has been
>>> introduced which takes struct task_struct as a parameter. Though,
>>> compiler doesn't know where to get information about it at this stage.
>>>
>>> Add missed declaration of struct task_struct to satisfy compiler.
>>>
>>> Fixes: 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")
>>> Cc: Kees Cook <keescook@chromium.org>
>>> Cc: James Morris <james.l.morris@oracle.com>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
>>
>> I'm not sure who should carry this. You're welcome to put it in your tree?
>
> I haven't seen this show up in linux-next. Andy will you be taking it?

Will be in next next.

-- 
With Best Regards,
Andy Shevchenko