From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Markus Metzger <markus.t.metzger@intel.com>
Subject: Re: [PATCH v2] perf: Suppress AUX/OVERWRITE records
Date: Fri, 4 May 2018 12:36:40 -0300 [thread overview]
Message-ID: <20180504153640.GC2700@redhat.com> (raw)
In-Reply-To: <20180504153534.GB2700@redhat.com>
Em Fri, May 04, 2018 at 12:35:34PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, May 04, 2018 at 03:09:59PM +0300, Alexander Shishkin escreveu:
> > On Wed, Apr 04, 2018 at 05:53:23PM +0300, Alexander Shishkin wrote:
> > > It has been pointed out to me many times that it is useful to be able
> > > to switch off AUX records to save the bandwidth for records that actually
> > > matter, for example, in AUX overwrite mode.
> > >
> > > The usefulness of PERF_RECORD_AUX is in some of its flags, like the
> > > TRUNCATED flag that tells the decoder where exactly gaps in the trace are.
> > > The OVERWRITE flag, on the other hand will be set on every single record
> > > in overwrite mode. However, a PERF_RECORD_AUX[flags=OVERWRITE] is
> > > generated on every target task's sched_out, which over time adds up to
> > > a lot of useless information.
> > >
> > > If any folks out there have userspace that depends on a constant stream of
> > > OVERWRITE records for a good reason, they'll have to let us know.
> > >
> > > Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > > Cc: Markus Metzger <markus.t.metzger@intel.com>
> > > Cc: Adrian Hunter <adrian.hunter@intel.com>
> >
> > This one seems to be slipping through the cracks.
>
> So, did you got Acked-by or tested-by from anyone?
Yeah, tons of them, I'll pick this up
- Arnaldo
next prev parent reply other threads:[~2018-05-04 15:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 12:30 [PATCH v1 0/4] perf: Allow suppressing useless AUX records Alexander Shishkin
2017-11-14 12:30 ` [PATCH v1 1/4] perf: Allow suppressing " Alexander Shishkin
2017-11-15 12:00 ` Peter Zijlstra
2018-01-15 15:00 ` [PATCH] " Alexander Shishkin
2018-03-29 11:54 ` Peter Zijlstra
2018-03-31 9:35 ` Ingo Molnar
2018-04-03 17:32 ` Will Deacon
2018-04-04 14:53 ` [PATCH v2] perf: Suppress AUX/OVERWRITE records Alexander Shishkin
2018-05-04 12:09 ` Alexander Shishkin
2018-05-04 15:35 ` Arnaldo Carvalho de Melo
2018-05-04 15:36 ` Arnaldo Carvalho de Melo [this message]
2018-09-25 9:27 ` [tip:perf/core] " tip-bot for Alexander Shishkin
2017-11-14 12:30 ` [PATCH v1 2/4] tools, perf_event.h: Synchronize Alexander Shishkin
2017-11-14 12:30 ` [PATCH v1 3/4] perf tools: Add 'suppress_aux' attribute bit definition and fallback Alexander Shishkin
2017-11-14 12:30 ` [PATCH v1 4/4] perf intel-pt, intel-bts: Suppress useless AUX records by default Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504153640.GC2700@redhat.com \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@intel.com \
--cc=mingo@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome