* [PATCH 0/2] [GIT PULL] tracing: Minor fixes
@ 2018-05-04 15:52 Steven Rostedt
2018-05-04 15:52 ` [PATCH 1/2] ftrace: Have set_graph_* files have normal file modes Steven Rostedt
2018-05-04 15:52 ` [PATCH 2/2] tracing: Fix the file mode of stack tracer Steven Rostedt
0 siblings, 2 replies; 5+ messages in thread
From: Steven Rostedt @ 2018-05-04 15:52 UTC (permalink / raw)
To: linux-kernel; +Cc: Linus Torvalds, Ingo Molnar, Andrew Morton
Linus,
Some of the files in the tracing directory show file mode 0444
when they are writable by root. To fix the confusion, they should
be 0644. Note, either case root can still write to them.
Note, Zhengyuan asked why I never applied that patch (the first one
is from 2014!). I simply forgot about it. /me lowers head in shame.
Please pull the latest trace-v4.17-rc1-3 tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
trace-v4.17-rc1-3
Tag SHA1: b23eed18b73241c8aa5829cc6f570610ce65c93b
Head SHA1: 0c5a9acc8b4e878e761f735e144d4a7e4477d4e6
Chen LinX (1):
ftrace: Have set_graph_* files have normal file modes
Zhengyuan Liu (1):
tracing: Fix the file mode of stack tracer
----
kernel/trace/ftrace.c | 4 ++--
kernel/trace/trace_stack.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] ftrace: Have set_graph_* files have normal file modes
2018-05-04 15:52 [PATCH 0/2] [GIT PULL] tracing: Minor fixes Steven Rostedt
@ 2018-05-04 15:52 ` Steven Rostedt
2018-05-04 15:52 ` [PATCH 2/2] tracing: Fix the file mode of stack tracer Steven Rostedt
1 sibling, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2018-05-04 15:52 UTC (permalink / raw)
To: linux-kernel
Cc: Linus Torvalds, Ingo Molnar, Andrew Morton, Namhyung Kim, Chen LinX
[-- Attachment #1: 0001-ftrace-Have-set_graph_-files-have-normal-file-modes.patch --]
[-- Type: text/plain, Size: 1284 bytes --]
From: Chen LinX <linx.z.chen@intel.com>
The set_graph_function and set_graph_notrace file mode should be 0644
instead of 0444 as they are writeable. Note, the mode appears to be ignored
regardless, but they should at least look sane.
Link: http://lkml.kernel.org/r/1409725869-4501-1-git-send-email-linx.z.chen@intel.com
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Chen LinX <linx.z.chen@intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/ftrace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 16bbf062018f..8d83bcf9ef69 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -5514,10 +5514,10 @@ static __init int ftrace_init_dyn_tracefs(struct dentry *d_tracer)
ftrace_create_filter_files(&global_ops, d_tracer);
#ifdef CONFIG_FUNCTION_GRAPH_TRACER
- trace_create_file("set_graph_function", 0444, d_tracer,
+ trace_create_file("set_graph_function", 0644, d_tracer,
NULL,
&ftrace_graph_fops);
- trace_create_file("set_graph_notrace", 0444, d_tracer,
+ trace_create_file("set_graph_notrace", 0644, d_tracer,
NULL,
&ftrace_graph_notrace_fops);
#endif /* CONFIG_FUNCTION_GRAPH_TRACER */
--
2.17.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] tracing: Fix the file mode of stack tracer
2018-05-04 15:52 [PATCH 0/2] [GIT PULL] tracing: Minor fixes Steven Rostedt
2018-05-04 15:52 ` [PATCH 1/2] ftrace: Have set_graph_* files have normal file modes Steven Rostedt
@ 2018-05-04 15:52 ` Steven Rostedt
1 sibling, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2018-05-04 15:52 UTC (permalink / raw)
To: linux-kernel; +Cc: Linus Torvalds, Ingo Molnar, Andrew Morton, Zhengyuan Liu
[-- Attachment #1: 0002-tracing-Fix-the-file-mode-of-stack-tracer.patch --]
[-- Type: text/plain, Size: 956 bytes --]
From: Zhengyuan Liu <liuzhengyuan@kylinos.cn>
It looks weird that the stack_trace_filter file can be written by root
but shows that it does not have write permission by ll command.
Link: http://lkml.kernel.org/r/1518054113-28096-1-git-send-email-liuzhengyuan@kylinos.cn
Signed-off-by: Zhengyuan Liu <liuzhengyuan@kylinos.cn>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/trace_stack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c
index 3c7bfc4bf5e9..4237eba4ef20 100644
--- a/kernel/trace/trace_stack.c
+++ b/kernel/trace/trace_stack.c
@@ -472,7 +472,7 @@ static __init int stack_trace_init(void)
NULL, &stack_trace_fops);
#ifdef CONFIG_DYNAMIC_FTRACE
- trace_create_file("stack_trace_filter", 0444, d_tracer,
+ trace_create_file("stack_trace_filter", 0644, d_tracer,
&trace_ops, &stack_trace_filter_fops);
#endif
--
2.17.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/2] [GIT PULL] tracing: minor fixes
@ 2013-02-19 4:15 Steven Rostedt
0 siblings, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2013-02-19 4:15 UTC (permalink / raw)
To: linux-kernel; +Cc: Ingo Molnar, Andrew Morton, Frederic Weisbecker
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
Ingo,
Please pull the latest tip/perf/core tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
tip/perf/core
Head SHA1: 8c189ea64eea01ca20d102ddb74d6936dd16c579
Steven Rostedt (1):
tracing/syscalls: Allow archs to ignore tracing compat syscalls
Steven Rostedt (Red Hat) (1):
ftrace: Call ftrace cleanup module notifier after all other notifiers
----
arch/x86/include/asm/ftrace.h | 24 +++++++++++++++++++
arch/x86/include/asm/thread_info.h | 1 -
kernel/trace/ftrace.c | 46 +++++++++++++++++++++++++-----------
kernel/trace/trace_syscalls.c | 43 +++++++++++++++++++++++++++++----
4 files changed, 94 insertions(+), 20 deletions(-)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/2] [GIT PULL] tracing: Minor fixes
@ 2010-10-21 2:42 Steven Rostedt
0 siblings, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2010-10-21 2:42 UTC (permalink / raw)
To: linux-kernel; +Cc: Ingo Molnar, Andrew Morton, Frederic Weisbecker
Ingo,
Please pull the latest tip/perf/core tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
tip/perf/core
Steven Rostedt (2):
tracing: Prevent unloadable modules from using trace_bprintk()
tracing: Do not limit the size of the number of CPU buffers
----
include/linux/kernel.h | 21 +++++++++++++++++++--
kernel/trace/trace.c | 8 ++------
kernel/trace/trace_printk.c | 2 ++
3 files changed, 23 insertions(+), 8 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-04 15:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04 15:52 [PATCH 0/2] [GIT PULL] tracing: Minor fixes Steven Rostedt
2018-05-04 15:52 ` [PATCH 1/2] ftrace: Have set_graph_* files have normal file modes Steven Rostedt
2018-05-04 15:52 ` [PATCH 2/2] tracing: Fix the file mode of stack tracer Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2013-02-19 4:15 [PATCH 0/2] [GIT PULL] tracing: minor fixes Steven Rostedt
2010-10-21 2:42 [PATCH 0/2] [GIT PULL] tracing: Minor fixes Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome