From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Tai <thomas.tai@oracle.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexandru Gagniuc <mr.nuke.me@gmail.com>
Subject: Re: [PATCH] PCI/AER: add pcie TLP header information in the tracepoint
Date: Tue, 8 May 2018 09:34:59 -0400 [thread overview]
Message-ID: <20180508093459.092988b6@gandalf.local.home> (raw)
In-Reply-To: <a5578a08-2434-af48-7910-6f858e5477d6@oracle.com>
On Tue, 8 May 2018 09:25:01 -0400
Thomas Tai <thomas.tai@oracle.com> wrote:
> >>> TP_STRUCT__entry(
> >>> __string( dev_name, dev_name )
> >>> __field( u32, status )
> >>> __field( u8, severity )
> >>> + __field( u32, tlp_header_valid)
> >
> > I'm guessing tlp_header_valid is just a boolean. It's after severity
> > which is just one byte long. Why not make this one byte as well,
> > otherwise you are wasting 3 bytes.
>
> Thanks Steven. Yes boolean is fine.
But don't use "bool", use u8, as bool can be various sizes on different
archs.
-- Steve
next prev parent reply other threads:[~2018-05-08 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 15:47 Thomas Tai
2018-05-07 22:21 ` Bjorn Helgaas
2018-05-07 22:35 ` Thomas Tai
2018-05-08 13:07 ` Steven Rostedt
2018-05-08 13:25 ` Thomas Tai
2018-05-08 13:34 ` Steven Rostedt [this message]
2018-05-08 13:35 ` Thomas Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508093459.092988b6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mr.nuke.me@gmail.com \
--cc=thomas.tai@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®