[PATCH 1/2] phy: qcom-qmp: Quiet -EPROBE_DEFER from qcom_qmp_phy_probe()

[PATCH 1/2] phy: qcom-qmp: Quiet -EPROBE_DEFER from qcom_qmp_phy_probe()

[Douglas Anderson]

The -EPROBE_DEFER virus demands special case code to avoid printing
error messages when the error is only -EPROBE_DEFER.  Spread the virus
to a new host: qcom_qmp_phy_probe().  Specifically handle when our
regulators might not be ready yet.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 6470c5d61d1c..a740daa58b31 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -1447,7 +1447,9 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
 
 	ret = qcom_qmp_phy_vreg_init(dev);
 	if (ret) {
-		dev_err(dev, "failed to get regulator supplies\n");
+		if (ret != -EPROBE_DEFER)
+			dev_err(dev, "failed to get regulator supplies: %d\n",
+				ret);
 		return ret;
 	}
 
-- 
2.17.0.441.gb46fe60e1d-goog

[PATCH 2/2] phy: qcom-qusb2: Quiet -EPROBE_DEFER from qusb2_phy_probe()

[Douglas Anderson]

The -EPROBE_DEFER virus demands special case code to avoid printing
error messages when the error is only -EPROBE_DEFER.  Spread the virus
to a new host: qusb2_phy_probe().  Specifically handle when our
regulators might not be ready yet.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
index 94afeac1a19e..26354618fd45 100644
--- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
@@ -711,7 +711,9 @@ static int qusb2_phy_probe(struct platform_device *pdev)
 
 	ret = devm_regulator_bulk_get(dev, num, qphy->vregs);
 	if (ret) {
-		dev_err(dev, "failed to get regulator supplies\n");
+		if (ret != -EPROBE_DEFER)
+			dev_err(dev, "failed to get regulator supplies: %d\n",
+				ret);
 		return ret;
 	}
 
-- 
2.17.0.441.gb46fe60e1d-goog

Re: [PATCH 2/2] phy: qcom-qusb2: Quiet -EPROBE_DEFER from qusb2_phy_probe()

[Vivek Gautam]

Hi Doug,


On 5/15/2018 4:12 AM, Douglas Anderson wrote:
> The -EPROBE_DEFER virus demands special case code to avoid printing
> error messages when the error is only -EPROBE_DEFER.  Spread the virus
> to a new host: qusb2_phy_probe().  Specifically handle when our
> regulators might not be ready yet.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
>   drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> index 94afeac1a19e..26354618fd45 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> @@ -711,7 +711,9 @@ static int qusb2_phy_probe(struct platform_device *pdev)
>   
>   	ret = devm_regulator_bulk_get(dev, num, qphy->vregs);
>   	if (ret) {
> -		dev_err(dev, "failed to get regulator supplies\n");
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(dev, "failed to get regulator supplies: %d\n",
> +				ret);
>   		return ret;
>   	}
>   
Thanks for the patch.
Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>

regards
Vivek

Re: [PATCH 1/2] phy: qcom-qmp: Quiet -EPROBE_DEFER from qcom_qmp_phy_probe()

[Vivek Gautam]

Hi Doug,


On 5/15/2018 4:12 AM, Douglas Anderson wrote:
> The -EPROBE_DEFER virus demands special case code to avoid printing
> error messages when the error is only -EPROBE_DEFER.  Spread the virus
> to a new host: qcom_qmp_phy_probe().  Specifically handle when our
> regulators might not be ready yet.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
>   drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 6470c5d61d1c..a740daa58b31 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -1447,7 +1447,9 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
>   
>   	ret = qcom_qmp_phy_vreg_init(dev);
>   	if (ret) {
> -		dev_err(dev, "failed to get regulator supplies\n");
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(dev, "failed to get regulator supplies: %d\n",
> +				ret);
>   		return ret;
>   	}
>   

Thanks for the patch. Looks good to me.
Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>

regards
Vivek

Re: [PATCH 1/2] phy: qcom-qmp: Quiet -EPROBE_DEFER from qcom_qmp_phy_probe()

[Doug Anderson]

Kishon,

On Mon, May 14, 2018 at 3:42 PM, Douglas Anderson <dianders@chromium.org> wrote:
> The -EPROBE_DEFER virus demands special case code to avoid printing
> error messages when the error is only -EPROBE_DEFER.  Spread the virus
> to a new host: qcom_qmp_phy_probe().  Specifically handle when our
> regulators might not be ready yet.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
>  drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I'm curious what you think of this patch and the next one.  Is it
something you'd apply or are you not interested?  Either way is fine
(it's just log spam) but I thought I'd check.  Thanks!  :)


-Doug