From: Joel Fernandes <joel@joelfernandes.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: rostedt@goodmis.org, byungchul.park@lge.com,
mathieu.desnoyers@efficios.com,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: Tasks RCU vs Preempt RCU
Date: Sat, 19 May 2018 17:56:54 -0700 [thread overview]
Message-ID: <20180520005632.GA58902@joelaf.mtv.corp.google.com> (raw)
In-Reply-To: <20180520004938.GZ3803@linux.vnet.ibm.com>
On Sat, May 19, 2018 at 05:49:38PM -0700, Paul E. McKenney wrote:
[...]
> > > And the problem with wrapping them with rcu_read_{lock,unlock} is that
> > > there would be a point before the trampoline executed rcu_read_lock()
> > > but while it was on the trampoline. Nothing good comes from this. ;-)
> >
> > Yes, I see what you're saying. The data being protected and freed in this
> > case is the code so relying on it to do the rcu_read_lock seems infeasible.
> > Conceptually atleast, I feel this can be fixed by cleverly implementing
> > trampolines such that the rcu_read_lock isn't done during the trampoline
> > execution. But I am not very experienced with how the trampolines work to say
> > definitely whether it is or isn't possible or worth it. But atleast I felt it
> > was a worthwhile food for thought ;)
>
> I suggested to Steven that the rcu_read_lock() and rcu_read_unlock() might
> be outside of the trampoline, but this turned out to be infeasible. Not
> that I remember why! ;-)
>
> > I actually want to trace out the trampoline executing as it pertains to RCU,
> > with your latest rcu/dev.. I think it will be fun :)
>
> Cool!
>
> In addition, if you are interested, it might be worth looking for fields
> in rcu_dynticks, rcu_data, rcu_node, and rcu_state that are no longer
> actually used. It might also be worth looking for RCU macros that are
> no longer used.
Yes, definitely interested. Will keep an eye out for such fields and macros.
thanks!
- Joel
next prev parent reply other threads:[~2018-05-20 0:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 18:36 Joel Fernandes
2018-05-19 2:29 ` Paul E. McKenney
2018-05-19 22:59 ` Joel Fernandes
2018-05-20 0:49 ` Paul E. McKenney
2018-05-20 0:56 ` Joel Fernandes [this message]
2018-05-20 15:28 ` Steven Rostedt
2018-05-20 19:18 ` Joel Fernandes
2018-05-22 1:59 ` Steven Rostedt
2018-05-22 4:34 ` Joel Fernandes
2018-05-22 4:54 ` Joel Fernandes
2018-05-22 12:38 ` Steven Rostedt
2018-05-22 16:09 ` Paul E. McKenney
2018-05-22 17:27 ` Steven Rostedt
2018-05-22 17:47 ` Paul E. McKenney
2018-05-23 1:19 ` Joel Fernandes
2018-05-23 3:10 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180520005632.GA58902@joelaf.mtv.corp.google.com \
--to=joel@joelfernandes.org \
--cc=byungchul.park@lge.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®