mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joel Fernandes <joel@joelfernandes.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	byungchul.park@lge.com, mathieu.desnoyers@efficios.com,
	Josh Triplett <josh@joshtriplett.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: Tasks RCU vs Preempt RCU
Date: Tue, 22 May 2018 18:19:11 -0700	[thread overview]
Message-ID: <20180523011911.GD55359@joelaf.mtv.corp.google.com> (raw)
In-Reply-To: <20180522174711.GY3803@linux.vnet.ibm.com>

On Tue, May 22, 2018 at 10:47:11AM -0700, Paul E. McKenney wrote:
> On Tue, May 22, 2018 at 01:27:00PM -0400, Steven Rostedt wrote:
> > On Tue, 22 May 2018 09:09:49 -0700
> > "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> > 
> > > Just for the record, if you guys realy want to take over Tasks RCU,
> > > I have no objections.  For one thing, I don't anticipate any other use
> > > cases for it (famous last words!).  But you break it, you buy it!  ;-)
> > 
> > It really matters how much of a burden is RCU_tasks to RCU itself? If
> > it causes a lot of headache for you, and it prevents you from cleaning
> > up RCU or making it better, then I would be happy to take it out of RCU
> > and maintain it separately myself. But if that's not the case, I'm happy
> > with keeping it within the RCU umbrella. Which brings me to the
> > question of what motivation does Joel have to remove it?
> 
> The burden on me from Tasks RCU has been quite light, so no need for a
> change from my end.
> 
> Over to you, Joel!  ;-)

My motivation was I felt RCU-preempt already did the same thing (which I
still believe it does) so its redundant. Although now I'm convinced from our
earlier discussions that its not feasible to do an rcu_read_lock and
rcu_read_unlock in trampoline code.

Sorry I didn't mean you should really nuke RCU-tasks if it has a purpose, but
I was more trying to understand what its purpose was that RCU-preempt didn't
solve. That's all.

And welcome back from Vacation Steve. I'm about to send v7 of my preempt/irq
tracepoint patches so the timing seems great. I hope you will be able to take
a look at them. thanks!

 - Joel

  reply	other threads:[~2018-05-23  1:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 18:36 Joel Fernandes
2018-05-19  2:29 ` Paul E. McKenney
2018-05-19 22:59   ` Joel Fernandes
2018-05-20  0:49     ` Paul E. McKenney
2018-05-20  0:56       ` Joel Fernandes
2018-05-20 15:28       ` Steven Rostedt
2018-05-20 19:18         ` Joel Fernandes
2018-05-22  1:59           ` Steven Rostedt
2018-05-22  4:34             ` Joel Fernandes
2018-05-22  4:54             ` Joel Fernandes
2018-05-22 12:38               ` Steven Rostedt
2018-05-22 16:09                 ` Paul E. McKenney
2018-05-22 17:27                   ` Steven Rostedt
2018-05-22 17:47                     ` Paul E. McKenney
2018-05-23  1:19                       ` Joel Fernandes [this message]
2018-05-23  3:10                 ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523011911.GD55359@joelaf.mtv.corp.google.com \
    --to=joel@joelfernandes.org \
    --cc=byungchul.park@lge.com \
    --cc=jiangshanlai@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome