From: Quentin Perret <quentin.perret@arm.com>
To: peterz@infradead.org, rjw@rjwysocki.net,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Cc: mingo@redhat.com, dietmar.eggemann@arm.com,
morten.rasmussen@arm.com, chris.redpath@arm.com,
patrick.bellasi@arm.com, valentin.schneider@arm.com,
vincent.guittot@linaro.org, thara.gopinath@linaro.org,
viresh.kumar@linaro.org, tkjos@google.com, joelaf@google.com,
smuckle@google.com, adharmap@quicinc.com, skannan@quicinc.com,
pkondeti@codeaurora.org, juri.lelli@redhat.com,
edubezval@gmail.com, srinivas.pandruvada@linux.intel.com,
currojerez@riseup.net, javi.merino@kernel.org,
quentin.perret@arm.com
Subject: [RFC PATCH v3 10/10] arch_topology: Start Energy Aware Scheduling
Date: Mon, 21 May 2018 15:25:05 +0100 [thread overview]
Message-ID: <20180521142505.6522-11-quentin.perret@arm.com> (raw)
In-Reply-To: <20180521142505.6522-1-quentin.perret@arm.com>
Energy Aware Scheduling starts when the scheduling domains are built if the
Energy Model is present and all conditions are met. However, in the typical
case of Arm/Arm64 systems, the Energy Model is provided after the scheduling
domains are first built at boot time, which results in EAS staying
disabled.
This commit fixes this issue by re-building the scheduling domain from the
arch topology driver, once CPUfreq is up and running and when the capacity
of the CPUs have been updated to their final value.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Quentin Perret <quentin.perret@arm.com>
---
drivers/base/arch_topology.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index e7cb0c6ade81..7f9fa10ef940 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -15,6 +15,8 @@
#include <linux/slab.h>
#include <linux/string.h>
#include <linux/sched/topology.h>
+#include <linux/energy_model.h>
+#include <linux/cpuset.h>
DEFINE_PER_CPU(unsigned long, freq_scale) = SCHED_CAPACITY_SCALE;
@@ -173,6 +175,9 @@ static cpumask_var_t cpus_to_visit;
static void parsing_done_workfn(struct work_struct *work);
static DECLARE_WORK(parsing_done_work, parsing_done_workfn);
+static void start_eas_workfn(struct work_struct *work);
+static DECLARE_WORK(start_eas_work, start_eas_workfn);
+
static int
init_cpu_capacity_callback(struct notifier_block *nb,
unsigned long val,
@@ -204,6 +209,7 @@ init_cpu_capacity_callback(struct notifier_block *nb,
free_raw_capacity();
pr_debug("cpu_capacity: parsing done\n");
schedule_work(&parsing_done_work);
+ schedule_work(&start_eas_work);
}
return 0;
@@ -249,6 +255,19 @@ static void parsing_done_workfn(struct work_struct *work)
free_cpumask_var(cpus_to_visit);
}
+static void start_eas_workfn(struct work_struct *work)
+{
+ /* Make sure the EM knows about the updated CPU capacities. */
+ rcu_read_lock();
+ em_rescale_cpu_capacity();
+ rcu_read_unlock();
+
+ /* Inform the scheduler about the EM availability. */
+ cpus_read_lock();
+ rebuild_sched_domains();
+ cpus_read_unlock();
+}
+
#else
core_initcall(free_raw_capacity);
#endif
--
2.17.0
next prev parent reply other threads:[~2018-05-21 14:26 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 14:24 [RFC PATCH v3 00/10] " Quentin Perret
2018-05-21 14:24 ` [RFC PATCH v3 01/10] sched: Relocate arch_scale_cpu_capacity Quentin Perret
2018-05-21 14:24 ` [RFC PATCH v3 02/10] sched/cpufreq: Factor out utilization to frequency mapping Quentin Perret
2018-05-21 14:24 ` [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework Quentin Perret
2018-06-06 13:12 ` Dietmar Eggemann
2018-06-06 14:37 ` Quentin Perret
2018-06-06 15:20 ` Juri Lelli
2018-06-06 15:29 ` Quentin Perret
2018-06-06 16:26 ` Quentin Perret
2018-06-07 15:58 ` Dietmar Eggemann
2018-06-08 13:39 ` Javi Merino
2018-06-08 15:47 ` Quentin Perret
2018-06-09 8:24 ` Javi Merino
2018-06-06 16:47 ` Juri Lelli
2018-06-06 16:59 ` Quentin Perret
2018-06-07 14:44 ` Juri Lelli
2018-06-07 15:19 ` Quentin Perret
2018-06-07 15:55 ` Dietmar Eggemann
2018-06-08 8:25 ` Quentin Perret
2018-06-08 9:36 ` Juri Lelli
2018-06-08 10:31 ` Quentin Perret
2018-06-08 12:39 ` Dietmar Eggemann
2018-06-08 13:11 ` Quentin Perret
2018-06-08 16:39 ` Dietmar Eggemann
2018-06-08 17:02 ` Quentin Perret
2018-06-07 16:04 ` Juri Lelli
2018-06-07 17:31 ` Quentin Perret
2018-06-09 8:13 ` Javi Merino
2018-06-19 11:07 ` Peter Zijlstra
2018-06-19 12:35 ` Quentin Perret
2018-06-19 11:31 ` Peter Zijlstra
2018-06-19 12:40 ` Quentin Perret
2018-06-19 11:34 ` Peter Zijlstra
2018-06-19 12:58 ` Quentin Perret
2018-06-19 13:23 ` Peter Zijlstra
2018-06-19 13:38 ` Quentin Perret
2018-06-19 14:16 ` Peter Zijlstra
2018-06-19 14:21 ` Peter Zijlstra
2018-06-19 14:30 ` Peter Zijlstra
2018-06-19 14:23 ` Quentin Perret
2018-05-21 14:24 ` [RFC PATCH v3 04/10] PM / EM: Expose the Energy Model in sysfs Quentin Perret
2018-06-19 12:16 ` Peter Zijlstra
2018-06-19 13:06 ` Quentin Perret
2018-05-21 14:25 ` [RFC PATCH v3 05/10] sched/topology: Reference the Energy Model of CPUs when available Quentin Perret
2018-06-07 14:44 ` Juri Lelli
2018-06-07 16:02 ` Quentin Perret
2018-06-07 16:29 ` Juri Lelli
2018-06-07 17:26 ` Quentin Perret
2018-06-19 12:26 ` Peter Zijlstra
2018-06-19 13:24 ` Quentin Perret
2018-06-19 16:20 ` Peter Zijlstra
2018-06-19 17:13 ` Quentin Perret
2018-06-19 18:42 ` Peter Zijlstra
2018-06-20 7:58 ` Quentin Perret
2018-05-21 14:25 ` [RFC PATCH v3 06/10] sched: Add over-utilization/tipping point indicator Quentin Perret
2018-06-19 7:01 ` Pavan Kondeti
2018-06-19 10:26 ` Dietmar Eggemann
2018-05-21 14:25 ` [RFC PATCH v3 07/10] sched/fair: Introduce an energy estimation helper function Quentin Perret
2018-06-08 10:30 ` Juri Lelli
2018-06-19 9:51 ` Pavan Kondeti
2018-06-19 9:53 ` Quentin Perret
2018-05-21 14:25 ` [RFC PATCH v3 08/10] sched: Lowest energy aware balancing sched_domain level pointer Quentin Perret
2018-05-21 14:25 ` [RFC PATCH v3 09/10] sched/fair: Select an energy-efficient CPU on task wake-up Quentin Perret
2018-06-08 10:24 ` Juri Lelli
2018-06-08 11:19 ` Quentin Perret
2018-06-08 11:59 ` Juri Lelli
2018-06-08 16:26 ` Quentin Perret
2018-06-19 5:06 ` Pavan Kondeti
2018-06-19 7:57 ` Quentin Perret
2018-06-19 8:41 ` Pavan Kondeti
2018-05-21 14:25 ` Quentin Perret [this message]
2018-06-19 9:18 ` [RFC PATCH v3 10/10] arch_topology: Start Energy Aware Scheduling Pavan Kondeti
2018-06-19 9:40 ` Quentin Perret
2018-06-19 9:47 ` Juri Lelli
2018-06-19 10:02 ` Quentin Perret
2018-06-19 10:19 ` Juri Lelli
2018-06-19 10:25 ` Quentin Perret
2018-06-19 10:31 ` Juri Lelli
2018-06-19 10:49 ` Quentin Perret
2018-06-01 9:29 ` [RFC PATCH v3 00/10] " Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521142505.6522-11-quentin.perret@arm.com \
--to=quentin.perret@arm.com \
--cc=adharmap@quicinc.com \
--cc=chris.redpath@arm.com \
--cc=currojerez@riseup.net \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=javi.merino@kernel.org \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=skannan@quicinc.com \
--cc=smuckle@google.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=thara.gopinath@linaro.org \
--cc=tkjos@google.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®