mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Andi Kleen <ak@linux.intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org,
	Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v2]: perf/x86: store user space frame-pointer value on a sample
Date: Wed, 23 May 2018 15:09:50 +0200	[thread overview]
Message-ID: <20180523130950.GB12217@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <7051f72e-2570-68c8-1488-33ad1b024031@linux.intel.com>

On Wed, May 23, 2018 at 01:06:58PM +0300, Alexey Budankov wrote:

> Is the patch ready to be up streamed now? 

Please post a new one where you modify the comment about the syscalls
not saving registers and ideally find the commit that made it so.

Also; I think Andy would appreciate a comment near the syscall code that
refers back to this code and states what registers we rely upon being
there (+BP for this patch).

  reply	other threads:[~2018-05-23 13:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 15:21 Alexey Budankov
2018-05-09 14:54 ` Peter Zijlstra
2018-05-10  9:42   ` Alexey Budankov
2018-05-10 10:14     ` Peter Zijlstra
2018-05-10 10:29       ` Alexey Budankov
2018-05-21 12:44       ` Alexey Budankov
2018-05-21 14:14         ` Andy Lutomirski
2018-05-21 16:51           ` Alexey Budankov
2018-05-21 17:23             ` Andy Lutomirski
2018-05-21 18:11               ` Alexey Budankov
2018-05-23 10:06       ` Alexey Budankov
2018-05-23 13:09         ` Peter Zijlstra [this message]
2018-05-24 14:37           ` Alexey Budankov
2018-05-24 14:52             ` Andy Lutomirski
2018-05-15  8:08   ` Alexey Budankov
2018-05-15 16:30     ` Andy Lutomirski
2018-05-16  8:42       ` Alexey Budankov
2018-05-18  7:39         ` Alexey Budankov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523130950.GB12217@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexey.budankov@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®