From: Arnd Bergmann <arnd@arndb.de>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
David Airlie <airlied@linux.ie>
Cc: Arnd Bergmann <arnd@arndb.de>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/8] drm/rcar-du: fix merge conflict for state->alpha
Date: Fri, 25 May 2018 17:50:11 +0200 [thread overview]
Message-ID: <20180525155030.3667352-4-arnd@arndb.de> (raw)
In-Reply-To: <20180525155030.3667352-1-arnd@arndb.de>
The "alpha" struct member was removed in one commit but another user
added in another, leading to a build failure:
drivers/gpu/drm/rcar-du/rcar_du_vsp.c: In function 'rcar_du_vsp_plane_atomic_duplicate_state':
drivers/gpu/drm/rcar-du/rcar_du_vsp.c:325:6: error: 'struct rcar_du_vsp_plane_state' has no member named 'alpha'
copy->alpha = to_rcar_vsp_plane_state(plane->state)->alpha;
This fixes up the merge by using the correct member.
Fixes: 75a07f399cd4 ("drm: rcar-du: Zero-out sg_tables when duplicating plane state")
Fixes: 301a9b8d5456 ("drm/rcar-du: Convert to the new generic alpha property")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
index 4a98470626d5..d9232e749b6d 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
@@ -322,7 +322,7 @@ rcar_du_vsp_plane_atomic_duplicate_state(struct drm_plane *plane)
return NULL;
__drm_atomic_helper_plane_duplicate_state(plane, ©->state);
- copy->alpha = to_rcar_vsp_plane_state(plane->state)->alpha;
+ copy->state.alpha = plane->state->alpha;
return ©->state;
}
--
2.9.0
next prev parent reply other threads:[~2018-05-25 15:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 15:50 [PATCH 1/8] drm/sun4i: mark PM functions as __maybe_unused Arnd Bergmann
2018-05-25 15:50 ` [PATCH 2/8] drm/amdgpu: fix 32-bit build warning Arnd Bergmann
2018-05-28 9:47 ` Oded Gabbay
2018-05-25 15:50 ` [PATCH 3/8] drm/xen-front: " Arnd Bergmann
2018-05-29 5:58 ` [Xen-devel] " Oleksandr Andrushchenko
2018-05-29 7:59 ` Arnd Bergmann
2018-05-25 15:50 ` Arnd Bergmann [this message]
2018-05-25 17:23 ` [PATCH 4/8] drm/rcar-du: fix merge conflict for state->alpha Laurent Pinchart
2018-05-25 15:50 ` [PATCH 5/8] drm/v3d: add CONFIG_MMU dependency Arnd Bergmann
2018-05-30 19:18 ` Eric Anholt
2018-05-25 15:50 ` [PATCH 6/8] drm/exynos: fix scaler_task_done return type Arnd Bergmann
2018-05-25 15:50 ` [PATCH 7/8] drm/bridge: fix dependency for lvds-encoder Arnd Bergmann
2018-05-28 7:47 ` Linus Walleij
2018-05-28 8:02 ` Laurent Pinchart
2018-05-28 8:06 ` Daniel Vetter
2018-05-28 11:10 ` Arnd Bergmann
2018-05-25 15:50 ` [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused Arnd Bergmann
2018-05-28 14:32 ` Boris Brezillon
2018-05-29 14:38 ` Thierry Reding
2018-05-28 9:19 ` [PATCH 1/8] drm/sun4i: " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525155030.3667352-4-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®