mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Inki Dae <inki.dae@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	David Airlie <airlied@linux.ie>
Cc: Arnd Bergmann <arnd@arndb.de>, Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/8] drm/exynos: fix scaler_task_done return type
Date: Fri, 25 May 2018 17:50:13 +0200	[thread overview]
Message-ID: <20180525155030.3667352-6-arnd@arndb.de> (raw)
In-Reply-To: <20180525155030.3667352-1-arnd@arndb.de>

Modern gcc versions warn about returning a ternary operator with an 'int'
type in a function returning type 'bool':

drivers/gpu/drm/exynos/exynos_drm_scaler.c: In function 'scaler_task_done':
drivers/gpu/drm/exynos/exynos_drm_scaler.c:402:47: error: ?: using integer constants in boolean context [-Werror=int-in-bool-context]
  return val & SCALER_INT_STATUS_FRAME_END ? 0 : -EINVAL;

>From context, it becomes clear that this should have been 'int',
so I'm fixing it, along with parenthesizing the expression to make
it clearer what is meant here (I got confused at first, after seeing
the warning).

Fixes: 01fb9185dc18 ("drm/exynos: Add driver for Exynos Scaler module")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/exynos/exynos_drm_scaler.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_scaler.c b/drivers/gpu/drm/exynos/exynos_drm_scaler.c
index 63b05b7c846a..4ad49d7782cd 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_scaler.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_scaler.c
@@ -397,9 +397,9 @@ static inline u32 scaler_get_int_status(struct scaler_context *scaler)
 	return scaler_read(SCALER_INT_STATUS);
 }
 
-static inline bool scaler_task_done(u32 val)
+static inline int scaler_task_done(u32 val)
 {
-	return val & SCALER_INT_STATUS_FRAME_END ? 0 : -EINVAL;
+	return (val & SCALER_INT_STATUS_FRAME_END) ? 0 : -EINVAL;
 }
 
 static irqreturn_t scaler_irq_handler(int irq, void *arg)
-- 
2.9.0

  parent reply	other threads:[~2018-05-25 15:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 15:50 [PATCH 1/8] drm/sun4i: mark PM functions as __maybe_unused Arnd Bergmann
2018-05-25 15:50 ` [PATCH 2/8] drm/amdgpu: fix 32-bit build warning Arnd Bergmann
2018-05-28  9:47   ` Oded Gabbay
2018-05-25 15:50 ` [PATCH 3/8] drm/xen-front: " Arnd Bergmann
2018-05-29  5:58   ` [Xen-devel] " Oleksandr Andrushchenko
2018-05-29  7:59     ` Arnd Bergmann
2018-05-25 15:50 ` [PATCH 4/8] drm/rcar-du: fix merge conflict for state->alpha Arnd Bergmann
2018-05-25 17:23   ` Laurent Pinchart
2018-05-25 15:50 ` [PATCH 5/8] drm/v3d: add CONFIG_MMU dependency Arnd Bergmann
2018-05-30 19:18   ` Eric Anholt
2018-05-25 15:50 ` Arnd Bergmann [this message]
2018-05-25 15:50 ` [PATCH 7/8] drm/bridge: fix dependency for lvds-encoder Arnd Bergmann
2018-05-28  7:47   ` Linus Walleij
2018-05-28  8:02   ` Laurent Pinchart
2018-05-28  8:06     ` Daniel Vetter
2018-05-28 11:10       ` Arnd Bergmann
2018-05-25 15:50 ` [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused Arnd Bergmann
2018-05-28 14:32   ` Boris Brezillon
2018-05-29 14:38     ` Thierry Reding
2018-05-28  9:19 ` [PATCH 1/8] drm/sun4i: " Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180525155030.3667352-6-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=airlied@linux.ie \
    --cc=andrzej.p@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®