From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Namhyung Kim <namhyung@kernel.org>
Subject: [for-next][PATCH 05/19] tracing: Have event_trace_init() called by trace_init_tracefs()
Date: Tue, 29 May 2018 11:23:09 -0400 [thread overview]
Message-ID: <20180529152326.694903697@goodmis.org> (raw)
In-Reply-To: <20180529152304.885389740@goodmis.org>
[-- Attachment #1: 0005-tracing-Have-event_trace_init-called-by-trace_init_t.patch --]
[-- Type: text/plain, Size: 2279 bytes --]
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Instead of having both trace_init_tracefs() and event_trace_init() be called
by fs_initcall() routines, have event_trace_init() called directly by
trace_init_tracefs(). This will guarantee order of how the events are
created with respect to the rest of the ftrace infrastructure. This is
needed to be able to assoctiate event files with ftrace internal events,
such as the trace_marker.
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/trace.c | 2 ++
kernel/trace/trace.h | 1 +
kernel/trace/trace_events.c | 4 +---
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index bcd93031d042..d5000cba5a27 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -8111,6 +8111,8 @@ static __init int tracer_init_tracefs(void)
if (IS_ERR(d_tracer))
return 0;
+ event_trace_init();
+
init_tracer_tracefs(&global_trace, d_tracer);
ftrace_init_tracefs_toplevel(&global_trace, d_tracer);
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 07c43960a704..d0319cbacf11 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -1451,6 +1451,7 @@ trace_find_event_field(struct trace_event_call *call, char *name);
extern void trace_event_enable_cmd_record(bool enable);
extern void trace_event_enable_tgid_record(bool enable);
+extern int event_trace_init(void);
extern int event_trace_add_tracer(struct dentry *parent, struct trace_array *tr);
extern int event_trace_del_tracer(struct trace_array *tr);
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index caf76355f0a3..5b647904a65b 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -3144,7 +3144,7 @@ static __init int event_trace_enable_again(void)
early_initcall(event_trace_enable_again);
-static __init int event_trace_init(void)
+__init int event_trace_init(void)
{
struct trace_array *tr;
struct dentry *d_tracer;
@@ -3189,8 +3189,6 @@ void __init trace_event_init(void)
event_trace_enable();
}
-fs_initcall(event_trace_init);
-
#ifdef CONFIG_FTRACE_STARTUP_TEST
static DEFINE_SPINLOCK(test_spinlock);
--
2.17.0
next prev parent reply other threads:[~2018-05-29 15:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 15:23 [for-next][PATCH 00/19] tracing: Updates for 4.18 Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 01/19] trace: Use -mcount-record for dynamic ftrace Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 02/19] tracepoints: Fix the descriptions of tracepoint_probe_register{_prio} Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 03/19] tracing: Do not reference event data in post call triggers Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 04/19] tracing: Add __find_event_file() to find event files without restrictions Steven Rostedt
2018-05-29 15:23 ` Steven Rostedt [this message]
2018-05-29 15:23 ` [for-next][PATCH 06/19] tracing: Add brackets in ftrace event dynamic arrays Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 07/19] tracing: Do not show filter file for ftrace internal events Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 08/19] tracing: Add trigger file for trace_markers tracefs/ftrace/print Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 09/19] tracing: Have zero size length in filter logic be full string Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 10/19] tracing: Prevent further users of zero size static arrays in trace events Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 11/19] tracing: Allow histogram triggers to access ftrace internal events Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 12/19] tracing: Document trace_marker triggers Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 13/19] ftrace/selftest: Have the reset_trigger code be a bit more careful Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 14/19] ftrace/selftest: Fix reset_trigger() to handle triggers with filters Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 15/19] tracing/selftest: Add selftests to test trace_marker histogram triggers Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 16/19] tracing/selftest: Add test to test hist trigger between kernel event and trace_marker Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 17/19] tracing/selftest: Add test to test simple snapshot trigger for trace_marker Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 18/19] ring-buffer: Fix a bunch of typos in comments Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 19/19] ring-buffer: Fix typo in comment Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529152326.694903697@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®