mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Namhyung Kim <namhyung@kernel.org>
Subject: [for-next][PATCH 07/19] tracing: Do not show filter file for ftrace internal events
Date: Tue, 29 May 2018 11:23:11 -0400	[thread overview]
Message-ID: <20180529152326.987381750@goodmis.org> (raw)
In-Reply-To: <20180529152304.885389740@goodmis.org>

[-- Attachment #1: 0007-tracing-Do-not-show-filter-file-for-ftrace-internal-.patch --]
[-- Type: text/plain, Size: 1442 bytes --]

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

The filter file in the ftrace internal events, like in
/sys/kernel/tracing/events/ftrace/function/filter is not attached to any
functionality. Do not create them as they are meaningless.

In the future, if an ftrace internal event gets filter functionality, then
it will need to create it directly.

Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 kernel/trace/trace_events.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 5b647904a65b..14ff4ff3caab 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -2007,16 +2007,18 @@ event_create_dir(struct dentry *parent, struct trace_event_file *file)
 			return -1;
 		}
 	}
-	trace_create_file("filter", 0644, file->dir, file,
-			  &ftrace_event_filter_fops);
 
 	/*
 	 * Only event directories that can be enabled should have
-	 * triggers.
+	 * triggers or filters.
 	 */
-	if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE))
+	if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) {
+		trace_create_file("filter", 0644, file->dir, file,
+				  &ftrace_event_filter_fops);
+
 		trace_create_file("trigger", 0644, file->dir, file,
 				  &event_trigger_fops);
+	}
 
 #ifdef CONFIG_HIST_TRIGGERS
 	trace_create_file("hist", 0444, file->dir, file,
-- 
2.17.0

  parent reply	other threads:[~2018-05-29 15:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 15:23 [for-next][PATCH 00/19] tracing: Updates for 4.18 Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 01/19] trace: Use -mcount-record for dynamic ftrace Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 02/19] tracepoints: Fix the descriptions of tracepoint_probe_register{_prio} Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 03/19] tracing: Do not reference event data in post call triggers Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 04/19] tracing: Add __find_event_file() to find event files without restrictions Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 05/19] tracing: Have event_trace_init() called by trace_init_tracefs() Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 06/19] tracing: Add brackets in ftrace event dynamic arrays Steven Rostedt
2018-05-29 15:23 ` Steven Rostedt [this message]
2018-05-29 15:23 ` [for-next][PATCH 08/19] tracing: Add trigger file for trace_markers tracefs/ftrace/print Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 09/19] tracing: Have zero size length in filter logic be full string Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 10/19] tracing: Prevent further users of zero size static arrays in trace events Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 11/19] tracing: Allow histogram triggers to access ftrace internal events Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 12/19] tracing: Document trace_marker triggers Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 13/19] ftrace/selftest: Have the reset_trigger code be a bit more careful Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 14/19] ftrace/selftest: Fix reset_trigger() to handle triggers with filters Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 15/19] tracing/selftest: Add selftests to test trace_marker histogram triggers Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 16/19] tracing/selftest: Add test to test hist trigger between kernel event and trace_marker Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 17/19] tracing/selftest: Add test to test simple snapshot trigger for trace_marker Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 18/19] ring-buffer: Fix a bunch of typos in comments Steven Rostedt
2018-05-29 15:23 ` [for-next][PATCH 19/19] ring-buffer: Fix typo in comment Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529152326.987381750@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®